| Summary: | [PATCH] Fix handling of invalid, non-path FPE | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Ademar Reis <ademar> |
| Component: | App/xfs | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Any special reason for not having included this patch on xfs-1.0.5? (In reply to comment #1) > Any special reason for not having included this patch on xfs-1.0.5? Only one I know of is lack of time/developers to review all patches from bugzilla before each release. I've confirmed the bug and that the patch fixes it, so pushed to master for the next release. Thanks for the patch. commit f7f149457581fa819c88e1958e7c154a6d9824fa Author: Ademar de Souza Reis Jr <ademar@mandriva.com.br> Date: Fri Dec 19 18:43:53 2008 -0800 Bug #11567: Fix handling of invalid, non-path FPE |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
FPE's which are not valid and are not in the form of paths cause a failure on the parser which invalidates all subsequent FPEs. If the invalid FPE is the first on the list, this will cause a fatal-error and the server will abort. Oneliner patch, reproduced below: (sent to xorg mailing-list some weeks ago) --- difs/fonts.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/difs/fonts.c b/difs/fonts.c index 2ba7c42..05fef26 100644 --- a/difs/fonts.c +++ b/difs/fonts.c @@ -688,6 +688,7 @@ set_font_path_elements( { NoticeF("ignoring font path element %s (bad font path descriptor)\n", name); fsfree(name); + cp += len; continue; } /* must be new -- make it */