| Summary: | xreg script uses csh/bash specific syntax for output redirection | ||
|---|---|---|---|
| Product: | Xtests | Reporter: | Pawel Worach <pawel.worach> |
| Component: | XTS | Assignee: | Kevin E. Martin <kem> |
| Status: | RESOLVED MOVED | QA Contact: | Xorg testing team <xorg-test> |
| Severity: | normal | ||
| Priority: | high | ||
| Version: | unspecified | ||
| Hardware: | x86 (IA32) | ||
| OS: | FreeBSD | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Proposed fix
Proposed fix 2 Take 3 |
||
Created attachment 718 [details] [review] Proposed fix Created attachment 719 [details] [review] Proposed fix 2 This script uses more bash specifics which i missed in my first glance. Make sure we use bash to execute it. Created attachment 720 [details] [review] Take 3 Don't use /proc to check if the X server is running, kill -0 <pid> is more portable as not every system has /proc these days. Also make the oprofile stuff Linux specific. product shift, xorg -> xtest. Kevin, how do these changes look to you? Pawel Worach Do you still experience this issue with newer soft ? Please check the status of your issue. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/test/xts/issues/6. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
/bin/sh is not bash on every system so be more gentle and use the >out 2>&1 style instead of >&. Patch is coming up.