| Summary: | Xserver ignores missing command-line given configuration file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Brice Goglin <brice.goglin> | ||||
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED MOVED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | normal | ||||||
| Priority: | medium | CC: | jesserayadkins | ||||
| Version: | 7.2 (2007.02) | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| URL: | http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=415584 | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
Created attachment 10989 [details] [review] abort when command-line given config file is missing, and add a message when switching to auto-config Can you make a patch generated by git format-patch, and send it to xorg-devel@lists.freedesktop.org? Patches made by git format-patch are easier to apply, and also preserve ownership (which may be useful to you later). You can also CC me, to make sure I don't miss the patch. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/xserver/issues/355. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Reported by Frederik Eaton on the Debian BTS several months ago. When a config file is given on the command line but does not exist, the Xserver displays an error but does not exit. It just switches to autoconfiguration (without being very clear in the log). It does not look like an acceptable behavior to Frederik (and me). It brings confusion since people might think their custom config file works, while actually the server only started thanks to autoconfig. The following tiny patch fixes this by: 1) reporting an error when xf86HandleConfigFile returns CONFIG_NOFILE and xf86ConfigFile was set: (EE) Unable to locate/open config file: "dummy" (EE) Command-line given config file "dummy" not found 2) printing a message when xf86ConfigFile wasn't set to show that we switch to autoconfiguration: (EE) Unable to locate/open config file (==) Default config file missing, switching to auto-configuration New driver is "i810" (==) Using default built-in configuration (55 lines) It applies to both Xserver 1.3 and current git. I only tested it on 1.3. I don't know whether it is acceptable to commit before the code freeze, I am posting all this here so that it doesn't get lost. Brice