Bug 122

Summary:	Xrender doesn't build out of CVS
Product:	xorg	Reporter:	Jon Kåre Hellan <hellan>
Component:	Lib/Xrender	Assignee:	Noah Levitt <nlevitt>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Jon Kåre Hellan 2003-10-06 12:48:18 UTC

Trying to build Xrender out of CVS with gnome jhbuild, I get

checking for render >= ... Comparison operator but no version after package name
'render' in file '(command line arguments)'
 
configure: error: Library requirements (render >= ) not met; consider adjusting
the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard
prefix so pkg-config can find them.

The problem seems to be in the configure.ac line
RENDER_VERSION=[`echo $VERSION | sed 's/^\([0-9][0-9]*\.[0-9][0-9]*\).*$/\1/'`]
where $VERSION isn't set.

This is probably the real problem behind bug 121. I told jamesh that Xrender
didn't build because of missing x11.pc. On closer examination, the reason turns
out to be as given here.

Comment 1 Noah Levitt 2003-10-06 15:35:28 UTC

What version of autoconf?

I'm not sure when VERSION wouldn't be set (it works for me). Does this patch fix
it for you?

Index: configure.ac
===================================================================
RCS file: /cvs/xlibs/Xrender/configure.ac,v
retrieving revision 1.14
diff -u -p -u -r1.14 configure.ac
--- configure.ac        1 Oct 2003 06:49:00 -0000       1.14
+++ configure.ac        6 Oct 2003 22:34:22 -0000
@@ -84,6 +84,9 @@ fi
 # Check render configuration, strip extra digits from package version to
 # find the required protocol version
 
+if test $VERSION = "" ; then
+        VERSION=$PACKAGE_VERSION
+fi
 RENDER_VERSION=[`echo $VERSION | sed 's/^\([0-9][0-9]*\.[0-9][0-9]*\).*$/\1/'`]
 PKG_CHECK_MODULES(RENDER, render >= $RENDER_VERSION)

Comment 2 Rob Adams 2003-11-01 20:01:47 UTC

using autoreconf version 2.57 on debian sid I ran into this problem.  I
independantly developed the same patch that you attached to this bug, which
fixes the problem for me.

using PACKAGE_VERSION instead of version ought to be safe for any version of
autoconf, no?

Comment 3 Trent "Lathiat" Lloyd 2003-11-26 21:14:35 UTC

That patch isnt quite right -- need quotes around $VERSION

--- configure.ac.orig   2003-11-27 13:13:04.000000000 +0800
+++ configure.ac        2003-11-27 13:09:09.000000000 +0800
@@ -84,6 +84,9 @@
 
 # Check render configuration, strip extra digits from package version to
 # find the required protocol version
+if test "$VERSION" = "" ; then
+       VERSION=$PACKAGE_VERSION;
+fi
 
 RENDER_VERSION=[`echo $VERSION | sed 's/^\([0-9][0-9]*\.[0-9][0-9]*\).*$/\1/'`]
 PKG_CHECK_MODULES(RENDER, render >= $RENDER_VERSION)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.