Bug 12578

Summary: renderproto-0.9.3: render.h does not compile
Product: xorg Reporter: Sami Farin <safari-ml-freedesktop-bugzilla-kv7oy2vp4mc4jvudr6vccb7oetrzzqe7fwnhahno>
Component: * OtherAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: eric, pachoramos1, remi
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
fix render.h compilation none

Description Sami Farin 2007-09-26 11:30:10 UTC 
$ gcc -c render.h
render.h:29: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘Glyph’
render.h:30: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘GlyphSet’
render.h:31: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘Picture’
render.h:32: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PictFormat’
Comment 1 Sami Farin 2007-09-26 11:31:05 UTC 
Created attachment 11766 [details] [review]
fix render.h compilation
Comment 2 Julien Cristau 2009-03-04 06:09:12 UTC 
*** Bug 20457 has been marked as a duplicate of this bug. ***
Comment 3 Rémi Cardona 2009-03-26 10:02:51 UTC 
Eric,

I'm CCing you because you made the commit that changed render.h's ulongs into XIDs.

Shouldn't Xdefs.h be included as well?

Thanks
Comment 4 Alan Coopersmith 2010-08-06 21:43:14 UTC 
Pushed to git master since several people have requested and no one objected:

commit 6122aa1ed38adbdf65e3ac11cff60bf075e85c0d
Author: Sami Farin <safari-ml-freedesktop....
Date:   Wed Sep 26 11:31:00 2007 -0700

    Bug 12578 - renderproto-0.9.3: render.h does not compile
    
    https://bugs.freedesktop.org/show_bug.cgi?id=12578

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.