Bug 12650

Created attachment 11854 [details] [review]
this patch hopefully fixes the problem

It seems the problem was due to the mouse sprite "context" not being properly updated when switching from one screen to another. Note that the switch from one screen to another was triggered by a call to miPointerWarpCursor().

So I have added a new function to the DIX layer: UpdateSpriteFromScreen() which basically updates the sprite context. That UpdateSpriteFromScreen() is now called by miPointerWarpCursor().

Okay, I have pushed the patch to the xserver, master branch. The commit is 81692b628f41cb64329f3cccc0503fb216a2b8e3.

So this should close the bug for now.

hi, since this patch apply,
mouse doesn't work anymore in enemy-territory (OpenGL game).
i tracked problem at around GenerateEvent.
are CursorLimits() or ConstrainCursor() or DisplayCursor() function corrent
in UpdateSpriteForScreen when GenerateEvent is true?
pointer move re-actived when apply this "all UpdateSpriteForScreen disabled when GenerateEvent is true patch".
it work xeyes on Xephyr in normal session.

diff --git a/mi/mipointer.c b/mi/mipointer.c
index 24ff4cc..79c9313 100644
--- a/mi/mipointer.c
+++ b/mi/mipointer.c
@@ -261,8 +261,8 @@ miPointerWarpCursor (pScreen, x, y)
        miPointer.x = x;
        miPointer.y = y;
        miPointer.pScreen = pScreen;
+       UpdateSpriteForScreen (pScreen) ;
     }
-    UpdateSpriteForScreen (pScreen) ;
 }
 
 /*

(In reply to comment #3)
> hi, since this patch apply,
> mouse doesn't work anymore in enemy-territory (OpenGL game).
> i tracked problem at around GenerateEvent.
> are CursorLimits() or ConstrainCursor() or DisplayCursor() function corrent
> in UpdateSpriteForScreen when GenerateEvent is true?
> pointer move re-actived when apply this "all UpdateSpriteForScreen disabled
> when GenerateEvent is true patch".
> it work xeyes on Xephyr in normal session.
> 
> diff --git a/mi/mipointer.c b/mi/mipointer.c
> index 24ff4cc..79c9313 100644
> --- a/mi/mipointer.c
> +++ b/mi/mipointer.c
> @@ -261,8 +261,8 @@ miPointerWarpCursor (pScreen, x, y)
>         miPointer.x = x;
>         miPointer.y = y;
>         miPointer.pScreen = pScreen;
> +       UpdateSpriteForScreen (pScreen) ;
>      }
> -    UpdateSpriteForScreen (pScreen) ;
>  }
> 
>  /*
> 

I'm pretty sure we need to call USFS even if we generate events. Can you please try the following patch:

diff --git a/mi/mipointer.c b/mi/mipointer.c
index 2c3c689..138e988 100644
--- a/mi/mipointer.c
+++ b/mi/mipointer.c
@@ -232,9 +232,13 @@ miPointerWarpCursor (pScreen, x, y)
     int                x, y;
 {
     SetupScreen (pScreen);
+    BOOL changedScreen = FALSE
 
     if (miPointer.pScreen != pScreen)
+    {
        (*pScreenPriv->screenFuncs->NewEventScreen) (pScreen, TRUE);
+        changedScreen = TRUE;
+    }
 
     if (GenerateEvent)
     {
@@ -255,7 +259,9 @@ miPointerWarpCursor (pScreen, x, y)
        miPointer.y = y;
        miPointer.pScreen = pScreen;
     }
-    UpdateSpriteForScreen (pScreen) ;
+
+    if (changedScreen)
+        UpdateSpriteForScreen (pScreen) ;
 }
 
 /*

thx.
I confirmed that it get back my mouse moving.

Pushed as 521a7f26e088029707fb9a2bb80c9ddc734a3f8b.