| Summary: | Decorator command not run at startup | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Colin Guthrie <colin> | ||||||
| Component: | App/compiz | Assignee: | David Reveman <reveman> | ||||||
| Status: | RESOLVED INVALID | QA Contact: | Xorg Project Team <xorg-team> | ||||||
| Severity: | normal | ||||||||
| Priority: | medium | ||||||||
| Version: | unspecified | ||||||||
| Hardware: | Other | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Colin Guthrie
2007-10-03 09:17:31 UTC
Created attachment 11879 [details] [review] Fix to ignore return value of the string setting This is not a final patch but it illustrates the point. This just adds a "|| TRUE" into the if statement but the final solution should be to remove the whole if() statement completely. A check further down will prevent the decorator command from being run if a decorator is already running. I have tested the behaviour and with the patch applied it seems to work as you'd expect (e.g. usefully!). The only reason I didn't remove the whole if statement is that I can't quite work out the indentation style at first glance (it's bizarre to me!), so I didn't want ot mess it up. It will take someone who is applying this seconds to adapt, so I figured it's was not worth me doing it badly! Cheers Created attachment 11880 [details] [review] Better patch This is a better patch. 1) I noticed the tabs and spaces combo in the file so the indentation seemed normal. 2) I realised there was a potential null string issue that this latest patch checks for. As maniac103 103 pointed out to me this patch does not fix things 100%. It works when using ccp as a config backend but does not work if compiz starts without any config backend. I will attempt to write a better patch. As maniac103 103 pointed out to me this patch does not fix things 100%. It works when using ccp as a config backend but does not work if compiz starts without any config backend. I will attempt to write a better patch. As maniac103 103 pointed out to me this patch does not fix things 100%. It works when using ccp as a config backend but does not work if compiz starts without any config backend. I will attempt to write a better patch. Mass closure: This bug has been untouched for more than six years, and is not obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.