Bug 12768

Summary:	Height metrics not correct
Product:	cairo	Reporter:	Richard Hult <richard>
Component:	quartz font backend	Assignee:	Carl Worth <cworth>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	medium	CC:	Brian.Ewins, sven.herzberg
Version:	1.5.1
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Uses ascent+descent+leading to get the distance between baselines

Description Richard Hult 2007-10-10 03:01:37 UTC

The height is currently mapped to the atsui metrics property capHeight, which is documented as "The height of a capital letter in the font from the baseline to the top of the letter".

That doesn't match what height is in cairo, it should be the disctance between baselines. Will attach a patch that fixes this (and makes webkit on GTK+ OS X layout nicely).

Comment 1 Richard Hult 2007-10-10 03:03:04 UTC

Created attachment 11965 [details] [review]
Uses ascent+descent+leading to get the distance between baselines

Comment 2 Richard Hult 2007-11-02 14:32:02 UTC

Adding Brian for feedback, hope that's OK.

Comment 3 Brian Ewins 2007-11-04 10:15:24 UTC

This looks obviously correct, thanks Richard. I've got this in my tree, I'll push it out as soon as Chris has the main branch building again (later today I expect)

Comment 4 Brian Ewins 2007-11-05 02:22:49 UTC

pushed as 4270cd3358fabf0d3e6ac4e866099b172082b592

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.