Bug 13073

Summary:	make dist in app/xcompmgr failsdue to broken long line
Product:	xorg	Reporter:	Peter Dyballa <Peter_Dyballa>
Component:	* Other	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	medium
Version:	7.1 (2006.05)
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Peter Dyballa 2007-11-03 13:47:18 UTC

(GIT_DIR=./.git git-log > .changelog.tmp && mv .changelog.tmp ChangeLog; rm -f .changelog.tmp) || (touch ChangeLog; echo 'git directory not
/bin/sh: -c: line 1: unexpected EOF while looking for matching `''
/bin/sh: -c: line 2: syntax error: unexpected end of file
make: *** [ChangeLog] Error 2

The reason is in Makefile.in and Makefile.am where a line is broken into two lines, faulty

ChangeLog:
	(GIT_DIR=$(top_srcdir)/.git git-log > .changelog.tmp && mv .changelog.tmp ChangeLog; rm -f .changelog.tmp) || (touch ChangeLog; echo 'git directory not
found: installing possibly empty changelog.' >&2)

instead of the correct

ChangeLog:
	(GIT_DIR=$(top_srcdir)/.git git-log > .changelog.tmp && mv .changelog.tmp ChangeLog; rm -f .changelog.tmp) || (touch ChangeLog; echo 'git directory not found: installing possibly empty changelog.' >&2)

Comment 1 Jamey Sharp 2007-11-05 09:32:55 UTC

The makefile is obviously broken and the proposed fix is obviously correct. Committed, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.