Bug 13250

Summary:	g_hash_table_get_values(...) call breaks viability with older distribution releases.
Product:	Telepathy	Reporter:	Peter Gordon <peter>
Component:	haze	Assignee:	Will Thompson <will>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	major
Priority:	low
Version:	unspecified
Hardware:	Other
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Reimplement g_hash_table_get_values so that haze builds with glib < 2.14.

Description Peter Gordon 2007-11-14 17:30:56 UTC

Hi, Will.

Part of the changes from 0.1.2 to 0.1.3 include a call to g_hash_table_get_values in the src/connection-manager.c:259 (the _init_protocol_table function).

Since this is a new symbol in GLib 2.14+, it precludes any telepathy-haze version updates for older-but-still-supported releases which use GLib 2.12, such as Fedora 7 and various architectures of Gentoo.

I would greatly appreciate it if that code were re-implemented using symbols available in GLib 2.12, or if that is not possible, to use #if conditionals to somehow use the "old" (0.1.2) code for that if the GLib version is too old.

Thanks.

Comment 1 Will Thompson 2007-11-15 04:13:04 UTC

Created attachment 12568 [details] [review]
Reimplement g_hash_table_get_values so that haze builds with glib < 2.14.

Ack, sorry.

I've re-implemented g_hash_table_get_values () to avoid the 2.14 dependency with the attached patch, which will be in darcs trunk shortly (modulo review) and in the next release.

Comment 2 Peter Gordon 2007-11-15 09:42:39 UTC

Thanks for the speedy fix! :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.