Bug 13268

Summary:	add support for inotify
Product:	dbus	Reporter:	Frederic Crozat <fred>
Component:	core	Assignee:	Havoc Pennington <hp>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	inotify support

Description Frederic Crozat 2007-11-16 00:57:15 UTC

Since this patch has been waiting on dbus mailing list for a long time, I figured I should upload here too so it is not forgotten ;)

It is adding inotify support for dbus, when available. It is based on dnotify and freedsb kqueue support already in dbus.

We've been using this patch on Mandriva Linux for about one year now.

Comment 1 Frederic Crozat 2007-11-16 00:57:40 UTC

Created attachment 12586 [details] [review]
inotify support

Comment 2 John (J5) Palmieri 2008-01-14 16:01:06 UTC

are you sure you've been using this patch over a year?  The detection code has some major flaws in it:

AC_CHECK_HEADERS(sys/inotify.h, have_inotify=no, have_inotify=yes) 

should be

AC_CHECK_HEADERS(sys/inotify.h, have_inotify=yes, have_inotify=no)

The other way around would turn off inotify if it existed

This check

 if x$target_os = xlinux-gnu -o x$target_os = xlinux -a test x$have_inotify = xno; then

should read as

 if test x$have_inotify = xno -a x$target_os = xlinux-gnu -o x$target_os = xlinux; then

otherwise dnotify would be turned on even when inotify is turned on.  The first statement reads a or (b and c).  The second a and (b or c).

Another bug was errno.h wasn't included

In any case, fixed and committed.  Can you comment at all on the errors before I close this bug?

Comment 3 Frederic Crozat 2008-01-15 09:14:53 UTC

arggg, you were right.. I guess I screwed up the configure part.

/me commits suicide ;)

closing bug as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.