Summary: | coordinates from XMoveWindow() treated incorrectly | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | Oleg Sukhodolsky <son.two> | ||||||||
Component: | App/compiz | Assignee: | David Reveman <reveman> | ||||||||
Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||
Severity: | normal | ||||||||||
Priority: | medium | CC: | erkinbah | ||||||||
Version: | 7.2 (2007.02) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux (All) | ||||||||||
Whiteboard: | |||||||||||
i915 platform: | i915 features: | ||||||||||
Attachments: |
|
Description
Oleg Sukhodolsky
2007-12-10 08:13:48 UTC
Created attachment 14964 [details] [review] Possible fix Here is a patch that seems to fix this problem. I didn't spot any bad side effects. It doesn't fix Java bug 6632124 though. Created attachment 15219 [details] [review] Better fix Better fix attempt. The patch in comment #1 only works for windows with NorthWestGravity. This fix should work for all kinds of gravity - please test. Created attachment 15220 [details] [review] Better fix, take 2 I just noticed that my first fix attempt didn't work correctly for e.g. SouthEastGravity. Inspection showed that seemingly just the north / west adjustments were missing from the moveResizeWindow function. Please test this one, it should work fine. (In reply to comment #3) > Created an attachment (id=15220) [details] > Better fix, take 2 > > I just noticed that my first fix attempt didn't work correctly for e.g. > SouthEastGravity. Inspection showed that seemingly just the north / west > adjustments were missing from the moveResizeWindow function. > Please test this one, it should work fine. After thinking a bit more about that, I decided that this fix is the correct one and thus pushed it. Should be fixed in commit 61f8473ed79d679f0c9dd068340b14ad964dda12. I tested the latest git version with your commits, and it works fine for all gravities. Thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.