Bug 13591

Summary: cairo-1.4.12: gmake check FAIL on check-def.sh
Product: cairo Reporter: acni <anirkko>
Component: generalAssignee: Carl Worth <cworth>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: medium    
Version: 1.4.9   
Hardware: SPARC   
OS: Solaris   
Whiteboard:
i915 platform: i915 features:

Description acni 2007-12-10 08:49:48 UTC
When building and checking cairo-1.4.12 on Solaris2.6,
`gmake check` FAILed (with a "please report") on check-def.sh
with the following output:

...
.../cairo-1.4.12/src/check-def.sh: bad substitution
FAIL: check-def.sh
.../cairo-1.4.12/src/check-plt.sh: !: not found
Checking .libs/lib*.so for local PLT entries
readelf: Error: '.libs/lib*.so': No such file
PASS: check-plt.sh
...
...
PASS: check-cairoint.sh
========================================================================
1 of 4 tests failed
Please report to http://bugs.freedesktop.org/enter_bug.cgi?product=cairo
========================================================================

running check-def manually complained about:

../cairo-1.4.12/src/check-def.sh: !: not found
make: Fatal error: Don't know how to make target `cairo.def'
../cairo-1.4.12/src/check-def.sh: bad substitution

(maybe a /bin/sh problem under older Solaris2.6 versions?
Also other packages such as gcc need /bin/ksh instead of /bin/sh
for building under Solaris)

substituting #!/bin/sh with #!/bin/ksh
made the complaint about "!: not found" go away.

but the error "make: Fatal error: Don't know how to make target `cairo.def'" remained when invoking check-def.sh manually.
Nevertheless, when invoking using `gmake check` (with /bin/ksh),
everything works.

Maybe the "master" make invoked (gmake instead of make) should also
be propagated into the tests?
Comment 1 Behdad Esfahbod 2007-12-10 11:37:36 UTC
I committed a fix for the make issue.

Cairo requires a sane POSIX sh and make to run the tests, so I wouldn't bother about the sh issue.
Comment 2 Behdad Esfahbod 2007-12-10 11:40:53 UTC
c26084a45fcb6ac467cad8bdcedfb2f524b857fc

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.