| Summary: | RFE: Allow enabling/disabling of more extensions | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Roland Mainz <roland.mainz> | ||||||||||||
| Component: | Server/General | Assignee: | Roland Mainz <roland.mainz> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | enhancement | ||||||||||||||
| Priority: | high | CC: | airlied, alan.coopersmith, eich, roland.mainz | ||||||||||||
| Version: | git | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Whiteboard: | |||||||||||||||
| i915 platform: | i915 features: | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Roland Mainz
2004-09-13 17:44:10 UTC
Created attachment 894 [details] [review] [FIXED_X11R68x] Patch for 2004-09-14-trunk Patch checked-in... /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.366; previous revision: 1.365 /cvs/xorg/xc/programs/Xserver/hw/xfree86/loader/dixsym.c,v <-- dixsym.c new revision: 1.6; previous revision: 1.5 /cvs/xorg/xc/programs/Xserver/include/globals.h,v <-- globals.h new revision: 1.5; previous revision: 1.4 /cvs/xorg/xc/programs/Xserver/mi/miinitext.c,v <-- miinitext.c new revision: 1.13; previous revision: 1.12 /cvs/xorg/xc/programs/Xserver/os/utils.c,v <-- utils.c new revision: 1.7; previous revision: 1.6 Mailing the commit message to xorg-commit@pdx.freedesktop.org... .. marking bug as FIXED. this patch breaks stuff, noXkbExtension is already defined in dixsym.c and noPanoramiXExtension is defined in extsym.c, current Xorg tree doesn't run on my system at least, until I comment out those two lines of the patch.... Dave Airlie wrote:
> this patch breaks stuff, noXkbExtension is already defined in dixsym.c and
> noPanoramiXExtension is defined in extsym.c,
> current Xorg tree doesn't run on my system at least, until I comment out those
> two lines of the patch....
Mhhh, at least "Xvfb"/"Xnest"/"Xprt" work "fine" here... may be the issue is
specific for the "Xorg" server... ;-( I'll take a look at the problem...
Some questions:
- Which platform do you use ?
- Do you use any special build options in host.def ?
- Which exact lines do you comment out ?
Just using Fedora Code 2 with top of tree checkout no special def files... missed a question, commented out the SYMVAR(noXkbExtension) and SYMVAR(noPanoramiXExtension), otherwise the X server crashes on startup with a duplicate symbol issue... Created attachment 895 [details] [review] Proposed fix for runtime bustage (fix for 2004-09-14-trunk) Dave Airlie: Can you please check whether the patch fixes your problem, please ? Created attachment 899 [details] [review] [FIXED_X11R68x] Fix for runtime bustage (patch for 2004-09-14-trunk Same patch as attachment #895 [details] [review], just added the Changelog entry. Umpf, no response from reporter since more than 10hours... I've checked-in the fix for now in the hope that it cures the problem: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.367; previous revision: 1.366 /cvs/xorg/xc/programs/Xserver/hw/xfree86/loader/dixsym.c,v <-- dixsym.c new revision: 1.7; previous revision: 1.6 /cvs/xorg/xc/programs/Xserver/hw/xfree86/loader/extsym.c,v <-- extsym.c new revision: 1.5; previous revision: 1.4 Mailing the commit message to xorg-commit@pdx.freedesktop.org... Marking bug as FIXED again. Please reopen if there are any issues left... Patch looks okay to me from here... I'll test it out when I get back to the system I was doing the work on,... (p.s. I had to go to bed in my timezone :-) Roland, you are aware that DAMAGE and COMPOSITE depend in XFIXES and there seems to be another dependency on RENDER (which I don't recall right now)? Egbert Eich wrote:
> Roland, you are aware that DAMAGE and COMPOSITE depend in XFIXES and there
> seems to be another dependency on RENDER (which I don't recall right now)?
Yes, I am aware about that. But I explicitly left out any dependicy checks since
it is unlikely that these are maintained (we're risking stale dependicies at
some point).
People who use these options should take care about the details and the init
code for the extensions itself should call |FatalError()| if mandatory
dependicies are not met.
I am going to make a patch to solve the dependicy issue tomorrow... Created attachment 938 [details] [review] [FIXED_X11R68x] Prototype for 2nd round: make extensins optional for the Xorg server (patch for 2004-09-18-trunk) Egbert: I am not sure what stuff is allowed in |staticExtensions| and what not. Can I simply stick all extensions in that array and assume the loader code will correctly figure out which extensions are really "static" (=built-in) or can I only list extensions there which are really built-in ? sndirsch: Can you please check whether the patche fixes the problem for you ? If the problem is gone the only remaining thing is Egbert's answer to the question in comment #11. Depending on that I make a final patch (which cleans another mess in that file up, too) ... > sndirsch: Can you please check whether the patche fixes the problem for
> you ?
Yes. DAMAGE no longer occurs in xdpyinfo, when disabled by
-extension DAMAGE
option or specifying
"Option "DAMAGE" "Off"
in "Extensions" section xorg.conf respectively.
*** Bug 1005 has been marked as a duplicate of this bug. *** *** Bug 1000 has been marked as a duplicate of this bug. *** Comment on attachment 894 [details] [review] [FIXED_X11R68x] Patch for 2004-09-14-trunk Requesting approval for X11R6.8.x (first part of bug 1361). This is clearly a feature patch but it is something nice-to-have and SuSE and others ship this patch with their version of X11R6.8.1 so the risk is low. Comment on attachment 899 [details] [review] [FIXED_X11R68x] Fix for runtime bustage (patch for 2004-09-14-trunk Requesting approval for X11R6.8.x (second part of bug 1361). Comment on attachment 938 [details] [review] [FIXED_X11R68x] Prototype for 2nd round: make extensins optional for the Xorg server (patch for 2004-09-18-trunk) Requesting approval for X11R6.8.x (third part of bug 1361). This is clearly a feature patch but it is something nice-to-have and SuSE and others ship this patch with their version of X11R6.8.1 so the risk is low. Created attachment 1287 [details] [review] [FIXED_X11R68x] Patch to disable DRI from initializing when -XFree86-DRI is passed When DRI is disabled, the server shouldn't initialize DRI, since it can't be used anyway. The attached patch uses the noXFree86DRIExtension var from previous patches to disable DRI if it has been disabled. Comment on attachment 894 [details] [review] [FIXED_X11R68x] Patch for 2004-09-14-trunk Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone call. Please don't commit it yourself, I'll handle that once the CVS service is available again. Comment on attachment 899 [details] [review] [FIXED_X11R68x] Fix for runtime bustage (patch for 2004-09-14-trunk Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone call. Please don't commit it yourself, I'll handle that once the CVS service is available again. Comment on attachment 938 [details] [review] [FIXED_X11R68x] Prototype for 2nd round: make extensins optional for the Xorg server (patch for 2004-09-18-trunk) Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone call. Please don't commit it yourself, I'll handle that once the CVS service is available again. Comment on attachment 1287 [details] [review] [FIXED_X11R68x] Patch to disable DRI from initializing when -XFree86-DRI is passed Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone call. Please don't commit it yourself, I'll handle that once the CVS service is available again. Comment on attachment 894 [details] [review] [FIXED_X11R68x] Patch for 2004-09-14-trunk Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.5; previous revision: 1.365.2.4 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/hw/xfree86/loader/dixsym.c,v <-- dixsym.c new revision: 1.5.2.1; previous revision: 1.5 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/include/globals.h,v <-- globals.h new revision: 1.4.2.1; previous revision: 1.4 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/mi/miinitext.c,v <-- miinitext.c new revision: 1.12.2.1; previous revision: 1.12 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/os/utils.c,v <-- utils.c new revision: 1.6.2.1; previous revision: 1.6 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Comment on attachment 899 [details] [review] [FIXED_X11R68x] Fix for runtime bustage (patch for 2004-09-14-trunk Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.6; previous revision: 1.365.2.5 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/hw/xfree86/loader/dixsym.c,v <-- dixsym.c new revision: 1.5.2.2; previous revision: 1.5.2.1 /cvs/xorg/xc/programs/Xserver/hw/xfree86/loader/extsym.c,v <-- extsym.c new revision: 1.4.2.1; previous revision: 1.4 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Comment on attachment 938 [details] [review] [FIXED_X11R68x] Prototype for 2nd round: make extensins optional for the Xorg server (patch for 2004-09-18-trunk) Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.7; previous revision: 1.365.2.6 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/mi/miinitext.c,v <-- miinitext.c new revision: 1.12.2.2; previous revision: 1.12.2.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Comment on attachment 1287 [details] [review] [FIXED_X11R68x] Patch to disable DRI from initializing when -XFree86-DRI is passed Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.8; previous revision: 1.365.2.7 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/GL/dri/dri.c,v <-- dri.c new revision: 1.6.2.1; previous revision: 1.6 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Grrr... for some xx@@@!!!-reason attachment #938 [details] [review] wasn't commited to Xorg trunk yet (it was shipped with SuSE 9.2 so there was hopefully enouth testing... ;-/) ... ;-( ... therefore: Attachment #938 [details] commited to Xorg trunk: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.583; previous revision: 1.582 /cvs/xorg/xc/programs/Xserver/mi/miinitext.c,v <-- miinitext.c new revision: 1.15; previous revision: 1.14 Mailing the commit message to xorg-commit@lists.freedesktop.org... Same problem (Patch not in Xorg trunk) applied to attachment #1287 [details] [review], too - fun... ;-(( Attachment #1287 [details] commited to Xorg trunk: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.584; previous revision: 1.583 /cvs/xorg/xc/programs/Xserver/GL/dri/dri.c,v <-- dri.c new revision: 1.7; previous revision: 1.6 Mailing the commit message to xorg-commit@lists.freedesktop.org... mass update: the fix for this bug was applied to both HEAD and the stable 6.8 branch, but the bug was never closed. closing now. *** Bug 1000 has been marked as a duplicate of this bug. *** |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.