Bug 13710

Summary: [xorg-server configure.ac] xf86bigfontproto, if enabled, needs to add its -I flags to cflags
Product: xorg Reporter: John Hein <jhein>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
fix configure.ac to list xf86fontproto as a REQUIRED_MODULES none

Description John Hein 2007-12-17 12:20:21 UTC
xf86bigfontproto does not list itself as a REQUIRED_MODULE in configure.ac when it is enabled.

Patch will be included shortly.
Comment 1 John Hein 2007-12-17 12:38:38 UTC
Created attachment 13167 [details] [review]
fix configure.ac to list xf86fontproto as a REQUIRED_MODULES

If xf86bigfont is enabled, add xf86fontproto to REQUIRED_MODULES.

This is needed to find xf86bigfont.h in dix/dixfonts.c

dix/dixfonts.c-#ifdef XF86BIGFONT
dix/dixfonts.c-#define _XF86BIGFONT_SERVER_
dix/dixfonts.c:#include <X11/extensions/xf86bigfont.h>
dix/dixfonts.c-#endif


This probably does not hit most people since other packages live in the same dir as xf86bigfontproto files.  But if xf86bigfontproto lives somewhere else, you need the appropriate -I flag from pkg-config --cflags xf86bigfontproto

The attached patch will ask the autoconf to generate a configure script to do that.
Comment 2 Eric Anholt 2009-02-01 09:27:48 UTC
commit ad8ffbe7cb50387e6a9cc4a24fea0d9c13b7bfc8
Author: John Hein <jhein@timing.com>
Date:   Fri Jan 30 21:30:35 2009 -0800

    Actually require bigfontproto when it's enabled.  Bug #13710.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.