Bug 1372

OK... who did remove Broadway support without making an official EOL notice ?
xx@@@!!!

Anyway... I have a patch for this which also solves the problem that libxrx
doesn't work with newer versions of Mozilla...

... taking bug myself.

Created attachment 918 [details] [review]
Prototype patch for 2004-09-15-trunk

Notes:
- The patch drops backwards-compatibility to Netscape3.x versions which use
statically linked Motif versions.
- Both plugins (xrx and xrxnest) now properly work with newer Mozilla versions
(older Mozilla versions had compatibility code - but that is broken since
several releases now... ;-( )

OK, Egbert said "go" for the restauration... :)

Created attachment 932 [details] [review]
[FIXED_X11R68x] Initial repair patch for 2004-09-17-trunk [checked-in]

Initial repair patch. I'll check that in in a few secs.

Remailing work to do:
- Check whether the plugins work in Konqueror
- Some code in the RxTearDown() function has been commented out - the real fix
may be to move that into a destructor callback which watches the plugin's base
widget
- On Linux the plugin should be installed in the matching default plugin
location (or a softlink)
- There should be a selector for Linux which probes the Linux version and makes
the decision whether libxrx.so or libxrxnest.so should be installed (libxrx.so
only work if the Xserver listening to TCP connections).

attachment 932 [details] [review] checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.378; previous revision: 1.377
/cvs/xorg/xc/config/cf/X11.tmpl,v  <--  X11.tmpl
new revision: 1.36; previous revision: 1.35
/cvs/xorg/xc/programs/xrx/Imakefile,v  <--  Imakefile
new revision: 1.4; previous revision: 1.3
/cvs/xorg/xc/programs/xrx/plugin/Imakefile,v  <--  Imakefile
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/xrx/plugin/Main.c,v  <--  Main.c
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/xrx/plugin/PProcess.c,v  <--  PProcess.c
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/xrx/xnest-plugin/Imakefile,v  <--  Imakefile
new revision: 1.2; previous revision: 1.1
/cvs/xorg/xc/programs/xrx/xnest-plugin/NewNDest.c,v  <--  NewNDest.c
new revision: 1.2; previous revision: 1.1
/cvs/xorg/xc/programs/xrx/xnest-plugin/SetWin.c,v  <--  SetWin.c
new revision: 1.2; previous revision: 1.1
/cvs/xorg/xc/programs/xrx/xnest-plugin/XnestDis.c,v  <--  XnestDis.c
new revision: 1.3; previous revision: 1.2
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... leaving bug open for further adjustments.

With BuildXprint and XprtServer both NO in host.def, libxrx.so fails to build:

+ gcc -m32 -o ./libxrx.so.6.8~ -shared -Wl,-soname,libxrx.so.6 Main.o SetWin.o
PProcess.o NewNDest.o Global.o stubs.o PRead.o PParse.o BuildReq.o XUrls.o
XAuth.o XDpyName.o Prefs.o -L../../../exports/lib -lXaw -lXmu -lXt -lSM -lICE
-lXpm -lXext -lX11 -lXt -lXp -lXext -lX11 -lc
/usr/lib/gcc/i686-pc-linux-gnu/3.4.2/../../../../i686-pc-linux-gnu/bin/ld:
cannot find -lXp
collect2: ld returned 1 exit status
make[5]: *** [libxrx.so.6.8] Error 1

Created attachment 1105 [details] [review]
[FIXED_X11R68x] Patch to fix the build bustage when libXaw8 is not build [checked-in]

Comment on attachment 1105 [details] [review]
[FIXED_X11R68x] Patch to fix the build bustage when libXaw8 is not build [checked-in]

Patch checked-in

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.459; previous revision: 1.458
/cvs/xorg/xc/programs/Imakefile,v  <--	Imakefile
new revision: 1.9; previous revision: 1.8
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

sndirsch:
Two questions:
1. What is the default installation location for Netscape4.x/Mozilla plugins on
Linux ?
2. On SuSE Linux the normal Xserver is always started with "-nolisten tcp",
right ?

> 1. What is the default installation location for Netscape4.x/Mozilla plugins 
>    on Linux ? 
 
SuSE already dropped Netscape 4.x. Don't know how to find the Mozilla plugins, 
and I don't think that there is a standard place for them. 
 
> 2. On SuSE Linux the normal Xserver is always started with "-nolisten tcp", 
>    right ? 
 
Yes. 

I object to this patch going into 6.8.x: it is a feature addition, and I don't
believe it meets the criteria for being merged into a stable point release.

(In reply to comment #11)
> I object to this patch going into 6.8.x: it is a feature addition, and I don't
> believe it meets the criteria for being merged into a stable point release.

1. It's not really a "feature patch" as the stuff was already there since
X11R6.3. Unfortunately the Xfree86 project accidently removed this part of X11
shortly before Xorg grabbed a CVS snapshot to create the basis of their CVS so
the change was introduced into X11R6.7.0, causing several complaints about the
removal. I am just undoing what the Xfree86 people did and some repair work to
get it running on Solaris&co. again, add support for Mozilla (while depreciating
 all the hacks for Netscape 3.x support).
2. The plugins are build but not installed in the default location for plugins
so noone should be harmed by these patches, just two additional libs are build
and stuffed into /usr/X11R6/lib/

a) Relative to what we have in 6.8.x branch now, it is an additional feature. 
Its presence or otherwise in the past is irrelvant -- it has been missing from
6.7, 6.8, and 6.8.1 already.
b) If you want to add more stuff, please do it somewhere else.  This is a
browser plugin, dude!  It has absolutely no place in the monolithic tree.  If
you disagree, I hope you will support the bug I will immediately file to add
four VNC clients into the monolithic tree in time for 6.8.2 (really).

(In reply to comment #13)
> a) Relative to what we have in 6.8.x branch now, it is an additional feature.

OK, should we remove the Mesa update from X11R6.8.2 or all the other "features"
 added to the release branch ? Some features were taken by release-wranglers
(including these two patches as their only risk is that they may break the build
(which didn't happen in HEAD)), others were not (like all the i18n updates
excluding one (which I dislike a lot but they're all too risky)).
 
> Its presence or otherwise in the past is irrelvant -- it has been missing from
> 6.7, 6.8, and 6.8.1 already.

Yes, and we got seveal complains about that.

> b) If you want to add more stuff, please do it somewhere else.  This is a
> browser plugin, dude!  It has absolutely no place in the monolithic tree.

It has it's place there since X11R6.3 distribution. It belongs here, even if
_you_ are not able to realise that X11 is something bigger than _you_ can
imagine (I am slightly sick that you are permanently pestering against stuff you
seem to know nothing about. Just because _you_ don't know it doesn't really mean
it has to be removed ASAP. Really.).

> If
> you disagree, I hope you will support the bug I will immediately file to add
> four VNC clients into the monolithic tree in time for 6.8.2 (really).

Daniel: Please STOP the trolling. That's no longer funny.
(BTW: X11R6.8.2 is mainly done now)

Comment on attachment 1105 [details] [review]
[FIXED_X11R68x] Patch to fix the build bustage when libXaw8 is not build [checked-in]

Patch approved for commit into X11R6.8.x stable branch in the 2005-01-14
release-wranglers phone call.

Comment on attachment 932 [details] [review]
[FIXED_X11R68x] Initial repair patch for 2004-09-17-trunk [checked-in]

Patch approved for commit into X11R6.8.x stable branch in the 2005-01-14
release-wranglers phone call.

attachment #932 [details] [review] and attachment #1105 [details] [review] checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.131; previous revision: 1.365.2.130
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/config/cf/X11.tmpl,v  <--  X11.tmpl
new revision: 1.35.2.2; previous revision: 1.35.2.1
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Imakefile,v  <--  Imakefile
new revision: 1.8.2.1; previous revision: 1.8
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/xrx/Imakefile,v  <--  Imakefile
new revision: 1.3.2.1; previous revision: 1.3
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/xrx/plugin/Imakefile,v  <--  Imakefile
new revision: 1.2.4.1; previous revision: 1.2
/cvs/xorg/xc/programs/xrx/plugin/Main.c,v  <--  Main.c
new revision: 1.2.4.1; previous revision: 1.2
/cvs/xorg/xc/programs/xrx/plugin/PProcess.c,v  <--  PProcess.c
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/xrx/xnest-plugin/Imakefile,v  <--  Imakefile
new revision: 1.1.1.1.6.1; previous revision: 1.1.1.1
/cvs/xorg/xc/programs/xrx/xnest-plugin/NewNDest.c,v  <--  NewNDest.c
new revision: 1.1.1.1.6.1; previous revision: 1.1.1.1
/cvs/xorg/xc/programs/xrx/xnest-plugin/SetWin.c,v  <--  SetWin.c
new revision: 1.1.1.1.6.1; previous revision: 1.1.1.1
/cvs/xorg/xc/programs/xrx/xnest-plugin/XnestDis.c,v  <--  XnestDis.c
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

... marking bug as FIXED (I'll file new bugs for the remaining issues).

(In reply to comment #14)
> (In reply to comment #13)
> > a) Relative to what we have in 6.8.x branch now, it is an additional feature.
> 
> OK, should we remove the Mesa update from X11R6.8.2 or all the other "features"
>  added to the release branch ? Some features were taken by release-wranglers
> (including these two patches as their only risk is that they may break the build
> (which didn't happen in HEAD)), others were not (like all the i18n updates
> excluding one (which I dislike a lot but they're all too risky)).

No, I'm not saying that at all; I'm just saying that it should be considered as
an irrelevant feature, and not something random.

> > Its presence or otherwise in the past is irrelvant -- it has been missing from
> > 6.7, 6.8, and 6.8.1 already.
> 
> Yes, and we got seveal complains about that.

And complaints about adding it back in.

> It has it's place there since X11R6.3 distribution. It belongs here, even if
> _you_ are not able to realise that X11 is something bigger than _you_ can
> imagine (I am slightly sick that you are permanently pestering against stuff you
> seem to know nothing about. Just because _you_ don't know it doesn't really mean
> it has to be removed ASAP. Really.).

It's cute that you can't stick to arguing about the issues, but no, I understand
perfectly what it does.  A lot of things are in X and have been since R6.3. 
That doesn't mean they're all good ideas.  Should we revive everything that's
ever been dropped from X?

> > If
> > you disagree, I hope you will support the bug I will immediately file to add
> > four VNC clients into the monolithic tree in time for 6.8.2 (really).
> 
> Daniel: Please STOP the trolling. That's no longer funny.
> (BTW: X11R6.8.2 is mainly done now)

Despite your attempts to insist that everything I do is to troll, or because I
don't like you, or because I'm a fool, or because I don't know anything, or
because I'm malicious and want nothing more than to sabotage X (clearly), it's
not actually true.

#2363.