Bug 13737

Summary: XVideo renders RGB image incorrectry.
Product: xorg Reporter: Kusanagi Kouichi <slash>
Component: Driver/RadeonAssignee: xf86-video-ati maintainers <xorg-driver-ati>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: critical    
Priority: medium CC: ejsheldrake
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
testcase
none
expected result
none
actual result for 24 or 32 bpp image.
none
actual result for 16 bpp image.
none
partial fix
none
xrandr --verbose
none
xmame rendering pacman badly using rgb overlays
none
what pacman should look like none

Description Kusanagi Kouichi 2007-12-19 07:44:31 UTC
Hardware is RV280 [Radeon 9200].
Misrendering occures horizontal direction only.
Comment 1 Kusanagi Kouichi 2007-12-19 07:46:20 UTC
Created attachment 13220 [details]
testcase
Comment 2 Kusanagi Kouichi 2007-12-19 07:47:14 UTC
Created attachment 13221 [details]
expected result
Comment 3 Kusanagi Kouichi 2007-12-19 07:48:29 UTC
Created attachment 13222 [details]
actual result for 24 or 32 bpp image.
Comment 4 Kusanagi Kouichi 2007-12-19 07:49:31 UTC
Created attachment 13223 [details]
actual result for 16 bpp image.
Comment 5 Kusanagi Kouichi 2007-12-19 07:51:42 UTC
Created attachment 13224 [details] [review]
partial fix

Image is still rendered incorrectly if following conditions are met.
1. Image is 24 or 32 bpp.
2. (dest_w > src_w) && (dest_w < src_w * 2 / 3).
3. Mode is "1600x1200".
Comment 6 Kusanagi Kouichi 2007-12-19 07:52:22 UTC
Created attachment 13225 [details]
xrandr --verbose
Comment 7 Edward Sheldrake 2008-01-11 12:35:47 UTC
All 4 RGB overlay types appear to be broken on my RV350 (Radeon 9550 AGP).

Using http://www.blackfiveservices.co.uk/xvtestcard.shtml, the image appears to be stretched horizontally, also, for RGB24, red and blue channels are swapped.

Hardware is 32bit x86. Running today's git snapshot of xf86-video-ati with xserver 1.4.

Xmame set to use the radeon rgb overlays renders incorrectly, I tested xmame with the rgb overlays of a sis 650 and that renders correctly, so I do not think the bug is in xmame.
Comment 8 Edward Sheldrake 2008-01-11 12:55:33 UTC
Created attachment 13663 [details]
xmame rendering pacman badly using rgb overlays

xmame -vidmod 1 -force-yuv 0 pacman

screenshot taken with a digital camera
Comment 9 Edward Sheldrake 2008-01-11 12:56:11 UTC
Created attachment 13664 [details]
what pacman should look like
Comment 10 Michel Dänzer 2008-01-19 06:14:07 UTC
Patch pushed, thanks Kusanagi. Do you want to leave this open for comment #5 or open another bug for that?
Comment 11 Kusanagi Kouichi 2008-01-21 19:29:24 UTC
> Do you want to leave this open for comment #5 or open another bug for that?

I will open another bug for that. So please close this bug.
Comment 12 Michel Dänzer 2008-01-22 02:47:19 UTC
Closing per submitter (note that you can do this yourself :).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.