| Summary: | xdm hangs in a loop when invalid xpm bitmap is used for logo | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Vaclav Rehak <vasek> | ||||
| Component: | App/xdm | Assignee: | Alan Coopersmith <alan.coopersmith> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | high | CC: | alan.coopersmith, matthieu.herrb | ||||
| Version: | unspecified | ||||||
| Hardware: | x86 (IA32) | ||||||
| OS: | FreeBSD | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
Vaclav Rehak
2004-09-15 08:10:16 UTC
Created attachment 4739 [details] [review] Patch for fixing infinite loop on invalid xpm files. The code section that load de xpm did not check the return value, and always set true to valid xpm variable. Patch should be applied from xdm/ dir. ( remove my email and name if necessary from patch ) Looks good - I'll check in soon. Well, we should ask the question: Since Constantino has cared enough to generate a patch for xdm, does he want to become its maintainer? Commited to CVS head - thanks for the fix! (jg: how about CVS access to commit patches first, before going straight from bugzilla patch submitter to maintainer?) CVSROOT: /cvs/xorg Module name: app Changes by: alanc@kemper.freedesktop.org 06/02/24 18:09:00 Log message: 2006-02-24 Alan Coopersmith <alan.coopersmith@sun.com> * greeter/Login.c: Bug #1391 <https://bugs.freedesktop.org/show_bug.cgi?id=1391> Patch #4739 <https://bugs.freedesktop.org/attachment.cgi?id=4739> xdm hangs in a loop when invalid xpm bitmap is used for logo (Costantino Leandro <lcostantino@gmail.com>) Modified files: app/xdm/: ChangeLog app/xdm/greeter/: Login.c Revision Changes Path 1.27 +8 -0 app/xdm/ChangeLog http://cvs.freedesktop.org/xorg/app/xdm/ChangeLog 1.3 +18 -7 app/xdm/greeter/Login.c http://cvs.freedesktop.org/xorg/app/xdm/greeter/Login.c |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.