Bug 14107

Summary:	GRADIENT_FILL_RECT_H is undeclared
Product:	cairo	Reporter:	mehmet yasar <myasar>
Component:	win32 backend	Assignee:	cairo-bugs mailing list <cairo-bugs>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	medium	CC:	ajohnson
Version:	1.5.6
Hardware:	Other
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:

Description mehmet yasar 2008-01-17 02:01:02 UTC

I'm compiling Cairo for Win32 with mingw on Ubuntu dapper (6.06) and I have an error when compiling cairo-win32-printing-surface.c : GRADIENT_FILL_RECT_H is undeclared.

The definition of GRADIENT_FILL_RECT_H in the windows header is incorrect (the condition of definition is erroneous)

I have :
----- wingdi.h --------------
#if (WINVER > 0x500)
#define GRADIENT_FILL_RECT_H 0x00
#define GRADIENT_FILL_RECT_V 0x01
#define GRADIENT_FILL_TRIANGLE 0x02
#define GRADIENT_FILL_OP_FLAG 0xff
...
#endif
-------------------

That should be (it has been fixed with recent mingw):
-------------------
#if (WINVER >= 0x500)
#define GRADIENT_FILL_RECT_H 0x00
#define GRADIENT_FILL_RECT_V 0x01
#define GRADIENT_FILL_TRIANGLE 0x02
#define GRADIENT_FILL_OP_FLAG 0xff
...
#endif
-------------------

Cairo should test the definition of RADIENT_FILL_RECT_H after including windows.h.

Thanks

Comment 1 Adrian Johnson 2008-01-18 03:25:34 UTC

Fixed in git

http://gitweb.freedesktop.org/?p=cairo;a=commit;h=eabd28a655f8ddc73ff71583bb658db796e932cd

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.