Bug 1411

Summary:	[XKB] mt symbols file wrong
Product:	xkeyboard-config	Reporter:	Ramon Casha <rcasha>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high	Keywords:	patch
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Submitted correct /etc/X11/xkb/symbols/pc/mt patch file against symbols/mt

Description Ramon Casha 2004-09-18 09:36:54 UTC

The file /etc/X11/xkb/symbols/pc/mt is incorrect. Apparently XFree86 in MDK10.0
was using the file symbols/mt (which includes the gb keyboard), while XOrg in
MDK10.1 is using symbols/pc/mt (which includes the basic keyboard). Anyway below
is the modified file which works. Essentially I just copied the needed lines
from gb.
--------------
// Maltese keyboard map (based on MSA Standard DMS100)
// by Ramon Casha (ramon.casha@linux.org.mt)
//
// $XFree86: xc/programs/xkbcomp/symbols/pc/mt,v 1.3 2002/12/13 04:18:04 dawes Exp $

partial default alphanumeric_keys
xkb_symbols "basic" {

    include "pc/latin"

    name[Group1]="Maltese";

    // The following four sets are the four additional letters, with the UK
    // equivalents
    key <TLDE>  { [ cabovedot,  Cabovedot,        grave,      notsign ] };
    key <AD11>  { [ gabovedot,  Gabovedot,  bracketleft,    braceleft ] };
    key <AD12>  { [   hstroke,    Hstroke, bracketright,   braceright ] };
    key <LSGT>  { [ zabovedot,  Zabovedot,    backslash,          bar ] };

    // Euro symbol
    key <AE03>  { [         3,   EuroSign,     sterling               ] };

    // Long accent
    key <AE06>  { [         6, asciicircum, dead_circumflex, dead_circumflex ]  };

    // Normal accented vowels
    key <AD03>  { [         e,          E,       egrave,       Egrave ] };
    key <AD07>  { [         u,          U,       ugrave,       Ugrave ] };
    key <AD08>  { [         i,          I,       igrave,       Igrave ] };
    key <AD09>  { [         o,          O,       ograve,       Ograve ] };
    key <AC01>  { [         a,          A,       agrave,       Agrave ] };

    key <BKSL>  { [numbersign, asciitilde,   dead_grave,   dead_breve ] };
    key <AE02>  { [         2,   quotedbl,  twosuperior,    oneeighth ] };
    key <AC11>  { [apostrophe,         at, dead_circumflex, dead_caron] };

    include "level3(ralt_switch_multikey)"
};

Comment 1 Ramon Casha 2004-09-18 09:39:13 UTC

Created attachment 934 [details]
Submitted correct /etc/X11/xkb/symbols/pc/mt

Comment 2 Sergey V. Udaltsov 2006-06-05 13:32:39 UTC

As far as I can see, xkeyboard-config already contains this layout. Ramon, could
you please have a look whether it is ok for you, if not - provide a patch
against xkeyboard-config? Thanks...

Comment 3 Ramon Casha 2006-06-05 21:11:49 UTC

The "basic" layout is now correct, but the "us" variant is not. Do I submit a
patch against the "mt" symbols file itself?

Comment 4 Sergey V. Udaltsov 2006-06-06 00:32:57 UTC

yes please

Comment 5 Ramon Casha 2006-06-10 21:05:05 UTC

Created attachment 5873 [details] [review]
patch file against symbols/mt

the new file bases the us variant on the basic layout instead of mt(basic).

Comment 6 Sergey V. Udaltsov 2006-06-11 05:36:18 UTC

The patch is generally ok for me, except for the group name (we have some string
convention on them, you know). So I will apply it ASAP.

Comment 7 Ramon Casha 2006-06-11 20:58:51 UTC

Ok, but there's no such thing as "Maltian" letters :)
Technically, it's a Maltese keyboard based on the US layout, not a US keyboard
with Maltese letters.

Comment 8 Sergey V. Udaltsov 2006-06-12 02:53:52 UTC

Ghm... The general pattern for this situation is:

"XXX - US keyboard with XXXian letters/digits/digraphs/..."

Could you think of something along this line? Or at least closer to it? It
should start with "XXX - US keyboard ..." anyway.

Comment 9 Sergey V. Udaltsov 2006-06-12 16:26:50 UTC

Anyway, I committed your patch (except for the group name), so I am closing this
bug. If you have a good wording for the group name, just post it here and I'll
commit it as well.

Comment 10 Ramon Casha 2006-06-12 20:49:02 UTC

Then I guess it should be "Malta - Maltese keyboard with US layout"

Comment 11 Sergey V. Udaltsov 2006-06-13 15:09:26 UTC

(In reply to comment #10)
> Then I guess it should be "Malta - Maltese keyboard with US layout"
Ghm, but it is rather the other way around...
What about...
"Malta - US keyboard with Maltese layout"
? So we would not mention non-existing thing like "Maltian letters" or smth.

Comment 12 Ramon Casha 2006-06-13 20:03:19 UTC

No, quite the contrary. It's not a US keyboard, it's a Maltese keyboard - that's
the point. There are two layouts for Malta - the 47-key version and the 48-key
version. The 47-key version is based on the US layout and the 48-key version is
based on the UK layout but both are official Maltese keyboards.

Comment 13 Sergey V. Udaltsov 2006-06-14 01:28:35 UTC

I see now... OK, then let it be "Maltese keyboard with US layout".

Comment 14 Sergey V. Udaltsov 2006-06-14 14:43:42 UTC

The name is fixed in CVS.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.