Bug 14168

Summary: endian bug on powerpc
Product: xorg Reporter: Danny <moondrake>
Component: Driver/nouveauAssignee: Nouveau Project <nouveau>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: PowerPC   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Danny 2008-01-21 02:07:13 UTC
It seems there is still a endian bug with Xv:
playing movies requesting a YV12 colorspace show wrong colors (usually green people). It's the same for both xv ports.

For me (NV34 on ppc), it can be fixed  by applying the following patch:

--- nv_video.c~ 2008-01-21 11:33:53.000000000 +0900
+++ nv_video.c  2008-01-21 19:02:27.000000000 +0900
@@ -689,11 +689,7 @@
                        }
                if (e)  {
                        unsigned short *vud = (unsigned short *) vuvud;
-#if X_BYTE_ORDER == X_BIG_ENDIAN
-                       *vud = (vs[0]<<8) | (us[0] << 0);
-#else
                        *vud = vs[0] | (us[0]<<8);
-#endif
                        }
                dst += dstPitch ;
                src1 += srcPitch2;
Comment 1 Danny 2008-01-22 02:50:31 UTC
fixed.

Thank you!

Danny

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.