Bug 14181

Summary: Should tp_g_set_error_unsupported_handle_type raise NotImplemented?
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: trivial    
Priority: low    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Simon McVittie 2008-01-21 11:01:35 UTC 
tp_g_set_error_unsupported_handle_type has this in its documentation:

* FIXME: Shouldn't the error be NotImplemented? The spec doesn't always
* allow us to return that, though.

The distinction between tp_g_set_error_unsupported_handle_type and tp_g_set_error_invalid_handle_type is that the former is used for handle types which are defined by the spec, but for which the CM doesn't have a handle repository, while the latter is used for handle types which (at the time the CM was compiled) weren't mentioned by the spec.

Perhaps this is too subtle and we should just pick one.
Comment 1 Mikhail Zabaluev 2008-01-22 04:19:21 UTC 
(In reply to comment #0)
> Perhaps this is too subtle and we should just pick one.

The distinction will be lost in case the client library implements a later spec where new handle types are defined, and the CM is built to an older version. I vote for "unsupported" to be future-proof.
Comment 2 Simon McVittie 2009-01-20 04:50:28 UTC 
Fixed soon in 0.7.23

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.