Summary: | xf86-video-sunffb fails in FFBDacSaveScreen when client disconnects | ||||||
---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | Brice Goglin <brice.goglin> | ||||
Component: | Driver/other | Assignee: | Xorg Project Team <xorg-team> | ||||
Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
Severity: | normal | ||||||
Priority: | medium | ||||||
Version: | 7.3 (2007.09) | ||||||
Hardware: | Other | ||||||
OS: | All | ||||||
URL: | http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=455313 | ||||||
Whiteboard: | |||||||
i915 platform: | i915 features: | ||||||
Attachments: |
|
Description
Brice Goglin
2008-02-03 08:46:10 UTC
Adam Cécile says that the problem goes away when afbinit is installed. I am waiting for Bernhard opinion about this. I think I will change "AFB firmware not loaded" from X_INFO to X_WARNING so that people have more chance of finding such a problem. But I am wondering if it is actually possible to run without NoAccel and without the AFB firmware. It currently issues a warning in the log. But it cannot work for real and causes such crashes, we should make it an error. Bernhard does not seem to be helped by afbinit. But he wrote the attached patch to fix his problem. He says: "The problem seems to be that FFBSaveScreen uses GET_FFB_FROM_SCREEN, which is #defined as ((FFBPtr)(s)->devPrivates[CreatorScreenPrivateIndex].ptr) but CreatorScreenPrivateIndex and devPrivates seem to be only set in ffb_accel, not by ffb_driver. When initializing the server that due to some strange reason causes no problem[1], but when the last client exists and the server is doing a reset, CreatorScreenPrivateIndex is 5 here and points to strange values (0 or 0x10000 and stuff like that) thus causing an segfault. [1] On some other cards there might be no accelerator without additional stuff, thus already segfaulting when starting the X server here. That might exlain why it sometimes may already segfault when starting the server and why that segfault at the start no longer happens with some firmware package." Created attachment 15195 [details] [review] fix for Creator3D from Bernhard R. Link On Sun, Mar 16, 2008 at 12:20:38 -0700, bugzilla-daemon@freedesktop.org wrote: > --- Comment #3 from Brice Goglin <brice.goglin@ens-lyon.org> 2008-03-16 12:20:37 PST --- > Created an attachment (id=15195) > --> (http://bugs.freedesktop.org/attachment.cgi?id=15195) > fix for Creator3D from Bernhard R. Link > this was included in davem's commit 843d93e775cd46a0e24e1a725594fa2d942f14ba |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.