Bug 14361

Summary:	[PATCH] Try console mode browsers in xdg-open
Product:	Portland	Reporter:	Ville Skyttä <ville.skytta>
Component:	xdg-utils	Assignee:	Fathi Boudra <fabo>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	low	CC:	pablo
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Try some console mode browsers after other fallbacks generic_browsers.diff generic_browsers2.diff

Description Ville Skyttä 2008-02-03 13:42:32 UTC

Created attachment 14127 [details] [review]
Try some console mode browsers after other fallbacks

The attached patch improves xdg-open by adding some well known console mode browsers to the list of tested browsers when all other fallbacks fail, and prevents trying GUI browsers when $DISPLAY is not set in the same case.

Comment 1 Pablo Castellano (pablog) 2010-02-28 05:10:35 UTC

Patch looks good for me. I have updated it to be applied to the current cvs version and did some changes:

* added also links2
* added epiphany and konqueror if $DISPLAY exists.
* removed netscape. (Does anybody still use it?)

I doubted to add google-chrome / chromium.

Comment 2 Pablo Castellano (pablog) 2010-02-28 05:11:11 UTC

Created attachment 33639 [details] [review]
generic_browsers.diff

Comment 3 Pablo Castellano (pablog) 2010-02-28 06:04:10 UTC

Created attachment 33641 [details] [review]
generic_browsers2.diff

Comment 4 Fathi Boudra 2010-02-28 06:27:09 UTC

looks fine, applied.
I have added google-chrome.

Comment 5 Ville Skyttä 2010-02-28 10:54:05 UTC

(In reply to comment #4)
> I have added google-chrome.

In that case I'd suggest also adding chromium-browser.
http://dev.chromium.org/Home

Comment 6 Fathi Boudra 2010-02-28 11:39:19 UTC

chromium-browser added.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.