Bug 14451

Summary:	gfree symbol could collide with libgunicode's gfree symbol
Product:	poppler	Reporter:	Diego Elio Pettenò <flameeyes>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	medium	CC:	dmacks
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Diego Elio Pettenò 2008-02-10 10:30:48 UTC

This was gathered by one of my analysis scripts:

Symbol gfree@@ (64-bit UNIX System V ABI AMD x86-64 architecture) present 3 times
  /usr/lib64/libpoppler.so.2.0.0
  /usr/lib64/libgunicode.so.3.0.0
  /usr/kde/3.5/lib64/kde3/libkpdfpart.so

(Don't mind libkpdfpart)
I think gfree should be either renamed or hidden in poppler to avoid possible collisions, the name is quite generic as it is.

Comment 1 Brad Hards 2008-02-10 11:34:43 UTC

I am opposed - to rename this symbol will make future merging from xpdf harder.

Why do you think it should be renamed in poppler? Why not the other library?

Comment 2 Diego Elio Pettenò 2008-02-10 11:48:43 UTC

Really just because I think you're more active and open to discuss problems :)

Comment 3 Daniel Macks 2008-02-18 12:13:32 UTC

Is gfree (and the rest of goo for that matter) part of the public interface for poppler, or is it just internal implementation? That is, could gmem() become a private symbol and solve this mess?

Comment 4 Albert Astals Cid 2008-02-18 12:32:09 UTC

Techincally it's internal but there are lots of projects out there ignoring our suggestion not to use poppler internals and still using them so well, it's also kind of public.

Comment 5 Daniel Macks 2008-02-18 18:51:31 UTC

D'oh! Well, privatizing would sure break 'em of that habit:)

Maybe something to consider when there's a future ABI break for some other reason?

Comment 6 Albert Astals Cid 2012-12-15 16:11:01 UTC

I'm going to close this, to be honest we are not going to change it, so keeping it open is just silly. Hope not much people tries to use libgunicode and poppler at the same time

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.