Bug 14703

Created attachment 14617 [details]
Working 1024x768 (with no randr)

Created attachment 14618 [details]
regdump::Working 1152x864 (with no randr)

Created attachment 14619 [details]
regdump::broken 1152x864 (with randr 1.2)

Created attachment 14620 [details]
regdump::broken 1024x768 (with randr 1.2)

Hi, comparative dumps for a working scaled resolution (say 800x600) would be useful. Also, please state which randr12 scaling modes the problem occurs with --
different scaling modes can be set with 'xrandr --output LVDS-0 --set
SCALING_MODE <mode>', where <mode> is one of aspect, noscale, and fullscreen

Created attachment 14714 [details]
regdump: Working 800x600 w/randr 1.2 (Default scaling...Aspect?)

This reg dump is from the 800x600 res in randr 1.2 mode.  It uses the default scaling mode, which from my other experiments, appears to be 'aspect'.

More info to follow later today.

Alright I've run the battery of scaling options on all of the resolutions that randr 1.2 reports. 

            Aspect        No Scale       Fullscreen
1360x768     Works         Corrupt            Works
1280x800     Works         Corrupt            Works 
1152x864     Corrupt       Corrupt            Works
1280x768     Works         Corrupt            Works
1280x720     Works         Corrupt            Works
1024x724     Corrupt       Corrupt            SquiggleFont
800x600      Works         Clipped            SquiggleFont
640x480      Works         Clipped            SquiggleFont


'Corrupt' means the screen is corrupted and the lines are shifted as described above. 

'Clipped' means the screen is looks correct, but it has been (significantly) clipped.  Like I am looking into a small window in the screen. (Centered, btw)

'SquiggleFont' means that I can see the screen as it should be. (everything is aligned properly), but the fonts seem to have pixels shifted around.

So, in other words, it is readable, there are definite corruptions. 

Did you ever use the blob and noticed what scaling options nvidia-settings offered?

Could you make a picture of the SquiggleFont?

Could you check the broken aspect ratio modes, and see if they have some kind of message like: "scaling resolution for widescreen/portrait something"

I forgot to add, the message may appear in xorg log, about half way the output modeset, if that means anything to you.

>Did you ever use the blob and noticed what scaling options nvidia-settings
> offered?

I used the blob long, long ago. I THINK that it (unlike nv) used something like aspect.  I remember liking the nv driver better because every mode was fullscreen. 

> Could you make a picture of the SquiggleFont?

If I try to do a screen shot, it shows up just fine, so it seems like it is definitely a display problem.  I'll take a picture with my digital camera. 

>Could you check the broken aspect ratio modes, and see if they have some kind
> of message like: "scaling resolution for widescreen/portrait something"

Yes.  "Scaling resolution on a widescreen panel" is present in both of the broken modes (1152x864, 1024x768). I did notice something that I missed before. One of the modes is clipped on the bottom. (And it says: Scaling resolution on a portrait panel)

(BTW.  The panel is natively 1680x1050, but I left that resolution of all of the tests.)

Here's my exhaustive test results:

                 Result              Scaling_String
   1360x768      Clipped on Bottom   "Scaling resolution on a portrait panel"    
   1280x800      Works               None
   1152x864      Corrupt             "Scaling resolution on a widescreen panel"
   1280x768      Works               None  
   1280x720      Clipped on Bottom   "Scaling resolution on a portrait panel"
   1024x768      Corrupt             "Scaling resolution on a widescreen panel" 
   800x600       Clipped on Right    "Scaling resolution on a widescreen panel"
                  (~100 pixels)
   640x480       Clipped on Right    "Scaling resolution on a widescreen panel"
                  (~100 pixels)

Created attachment 14808 [details] [review]
Some corrections to the noscale scaling mode

See if this patch helps any with corruption of the noscale modes. If it does, it's worth seeing if "aspect" works better when regp->fp_hvalid_start and regp->fp_hvalid_end do not get set at nv_crtc.c lines ~1380 and ~1400.

Alright, I've tried the patch.  It completely fixes all of the "non-scaled" resolutions. (None of them are corrupt.) 

I still have to:
1) Take a Picture of squiggle font
2) Try the other fix you suggested for aspect. 

Here's my status with head+your patch: 

            Aspect        No Scale       Fullscreen
1360x768     Bottom Clip    Works             Works
1280x800     Works          Works             Works 
1152x864     Corrupt        Works             Works
1280x768     Works          Works             Works
1280x720     Bottom Clip    Works             Works
1024x768     Corrupt        Works             SquiggleFont
800x600      Right Clip     Works             SquiggleFont
640x480      Right Clip     Works             SquiggleFont

Hi, have you had any time to look at these remaining issues? I'd be very interested in the outcome of 2) especially

(In reply to comment #13)
> Hi, have you had any time to look at these remaining issues? I'd be very
> interested in the outcome of 2) especially
> 

Sorry. Didn't mean to fall off the face of the Earth.  Real life got in the way.  I'll give it a try later today. 

Cheers,
--Phil

Ok.  I tried the suggested change and it did make things better.

The output of "aspect" resolutions exactly matched those of the "fullscreen" resolutions.  So, for every resolution, none were clipped. 

This is definitely a step in the right direction.  However, since the output filled up the entire screen, it DIDN'T maintain the aspect ratio (like the mode's name implies...)   Maybe that's the best we can do...

BTW.  I have pictures of the "squiggle font" which I'll be uploading shortly. 

Alright, bugzilla won't let me attach these images... Too big.

Squiggle font @ 1024x768:
http://www.mediafire.com/?nnb7tmxl22f

Squiggle font @ 800x600:
(Notice that the screen also looks shifted to the right)
http://www.mediafire.com/?di1t3xwtwxh

Squiggle font @640x480:
(The screen looks rotated here, too..)
http://www.mediafire.com/?xui1mzwmc2f

Ok, I've merged up the noscale fix for now. Perhaps aspect is too much to hope for (do you have the binary blob installed -- if so, does nvidia-settings let you choose aspect scaling?), but fullscreen should work, since it does in non-randr.

So:
1) verify that non-randr scaling works at the problematic resolutions *after* randr12 has been used (i.e. no reboot between)
2) add to this bug the output of "radeontool regmatch $reg", for $reg of 0x680884, 0x682884, 0x680888, 0x682888

Randr 1.2 is now mandatory. Any news on this bug? How about KMS?

No reply from the reporter or the bug. Assuming one of them is dead. Closing as fixed.