Bug 14727

Summary: libXpm ansification
Product: xorg Reporter: Paulo César Pereira de Andrade <pcpa>
Component: Lib/XpmAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED NOTABUG QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: patch
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
0001-libXpm-ansification.patch none

Description Paulo César Pereira de Andrade 2008-02-28 15:46:55 UTC 
Created attachment 14670 [details] [review]
0001-libXpm-ansification.patch

This patch should be easy and cause no side effects as only "non promotable"
types are ever used.
Comment 1 Paulo César Pereira de Andrade 2008-07-23 13:28:42 UTC 
  Patch is not small, so requires some time to do
it "by hand", but is trivial, as there are no type
promotions (and talking for memory from when I
reviewed the patch) neither "traps" that can allow
easily redefining a prototype incorrectly by swaping
order of arguments, example of a "trap":

type foo(a, b, c)
    type a;
    type c;
    type b;

where a patch by hand could just change it to:

type foo(
    type a,
    type c,
    type b)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.