Bug 1485

Summary:	--enable-qt misleading, requires kdelibs
Product:	dbus	Reporter:	Kaj-Michael Lang <milang>
Component:	core	Assignee:	Havoc Pennington <hp>
Status:	RESOLVED FIXED	QA Contact:
Severity:	trivial
Priority:	high	CC:	aom
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Kaj-Michael Lang 2004-09-28 05:45:22 UTC

Took a while for me to figure out what was wrong as I did have QT installed.

The switch should be named --enable-kde or then configure should inform that
it's looking for kde libraries, not just plain QT.

Comment 1 Colin Walters 2004-10-29 09:48:15 UTC

Should probably be called --enable-kde3 actually, given that Qt 4 will have
D-BUS bindings.

Comment 2 Colin Walters 2004-10-29 09:50:10 UTC

*** Bug 1711 has been marked as a duplicate of this bug. ***

Comment 3 Thomas Braxton 2005-08-05 09:43:49 UTC

Created attachment 3261 [details] [review]
BRANCH_1_0 patch 2/2: Fix locking in _cairo_ft_scaled_font_text_to_glyphs

this patch also cleans up the Qt configuration logic a bit

Comment 4 Havoc Pennington 2005-08-05 10:49:39 UTC

Comment on attachment 3261 [details] [review]
BRANCH_1_0 patch 2/2: Fix locking in _cairo_ft_scaled_font_text_to_glyphs

I'd prefer have_qt be set to just "no" rather than with the parens saying QTDIR
not set; you could add a no_qt_explanation set to "" or "QTDIR not set" then
stick that variable in the end-of-configure summary for the same effect.

You need to handle the case that enable_qt=auto in addition to
enable_qt=yes/enable_qt=no. The default is auto which means "use it if it's
there" while "yes" means "error if we can't use it" and "no" means "don't ever
use it"

Spec file authors for example use --enable-qt=yes to require that the build
environment have qt, or --enable-qt=no to ignore qt even if the build env has
it.

To handle auto you might want to go back to the original arrangement of the
configure script and just change how qt is detected.

Comment 5 Thomas Braxton 2005-08-06 11:49:12 UTC

Created attachment 3277 [details]
ssh public key

This patch was tested for all cases of --enable-qt with
  - QTDIR set
  - QTDIR not set
  - QTDIR set to wrong directory
this should cover everything

Comment 6 Havoc Pennington 2005-08-07 05:00:40 UTC

Comment on attachment 3277 [details]
ssh public key

Looks great, thanks

Comment 7 John (J5) Palmieri 2005-08-24 21:57:18 UTC

Looks fixed. Closing

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.