Bug 1496

Created attachment 982 [details] [review]
Prototype patch

The prototype patch seems to work but I have to write a small test tool to be
sure.
The patch raises more issues:
- "xp-listfonts-mode" does not appear in "document-attributes-supported" nor in
"xp-page-attributes-supported", the question is whether this is intentional or
a normal bug
- xc/programs/Xserver/Xprint/OidStrs.h has '{ "xp-listfonts-modes", 18 }' -
note the 's' at the end of "xp-listfonts-modes" vs. "xp-listfonts-mode" used
elsewhere in the patch. That may be a typo... or not... ;-(
"dtprint_fspec.ps" talks about "xp-listfonts-modes" so I guess this is the
correct spelling... or not.
Only the DtPrint implementation can answer that question...

Created attachment 983 [details] [review]
Alternative patch which fixes the spelling of "xp-listfonts-modes"

Alternative patch which fixes the spelling of "xp-listfonts-modes" and adds
"xp-listfonts-modes" to both "document-attributes-supported" and
"xp-page-attributes-supported".

Comment on attachment 983 [details] [review]
Alternative patch which fixes the spelling of "xp-listfonts-modes"

Note: The PCL DDX needs to be updated, too...

Created attachment 997 [details] [review]
Hack for xpsimplehelloworld.c to verify the "xp-listfonts-modes" functionality

Hack for xpsimplehelloworld.c to verify the "xp-listfonts-modes" functionality.

The patch is mainly to verify that the patch from attachment #983 [details] [review] works.
Real-life applications should check whether "xp-listfonts-modes" is listed in
"document-attributes-supported" (for Document-level) or
"xp-page-attributes-supported" (for Page-level).

Created attachment 998 [details] [review]
[FIXED_X11R68x] Patch for 2004-10-03-trunk

The patch fixes the spelling of "xp-listfonts-modes" (the same functionality as
attachment #983 [details] [review] but updates the commets in the code and the PCL driver).

attachment 998 [details] [review] checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.423; previous revision: 1.422
/cvs/xorg/xc/programs/Xserver/Xprint/Init.c,v  <--  Init.c
new revision: 1.7; previous revision: 1.6
/cvs/xorg/xc/programs/Xserver/Xprint/pcl/PclInit.c,v  <--  PclInit.c
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsInit.c,v  <--  PsInit.c
new revision: 1.4; previous revision: 1.3
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.

Followup is bug 1518 ('"xlsfonts" should have printer support') ...

Note:
This cased bug 1629 ("Xprt in Xorg trunk crashes on AMD64") due a small memory
corruption problem. If this work gets approved for the X11R6.8.x stable branch
the fix from bug 1629 is needed, too.

Comment on attachment 998 [details] [review]
[FIXED_X11R68x] Patch for 2004-10-03-trunk

nominating for X11R6.8.2 as needed by the Qt library and KDE.

Comment on attachment 998 [details] [review]
[FIXED_X11R68x] Patch for 2004-10-03-trunk

Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone
call.
Please don't commit it yourself, I'll handle that once the CVS service is
available again.

Comment on attachment 998 [details] [review]
[FIXED_X11R68x] Patch for 2004-10-03-trunk

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.41; previous revision: 1.365.2.40
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/Init.c,v  <--  Init.c
new revision: 1.6.4.2; previous revision: 1.6.4.1
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/pcl/PclInit.c,v  <--  PclInit.c
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsInit.c,v  <--  PsInit.c
new revision: 1.3.4.2; previous revision: 1.3.4.1
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...