Bug 15588

Summary:	[patch] userdb cache is never compiled due to mismatched #defs
Product:	dbus	Reporter:	Scott James Remnant <scott>
Component:	core	Assignee:	Havoc Pennington <hp>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	normal
Priority:	medium	CC:	thoenig, walters
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch to correct it Patch in preferred format

Description Scott James Remnant 2008-04-18 12:50:33 UTC

Created attachment 16023 [details] [review]
Patch to correct it

configure.in will #define DBUS_ENABLE_USERDB_CACHE if --disable-userdb-cache is not passed.

However dbus/dbus-userdb{,-util}.c will only enable the code if DBUS_ENABLE_USER_CACHE is defined.

So the userdb cache is currently broken.

Comment 1 Scott James Remnant 2008-04-24 08:03:34 UTC

Created attachment 16157 [details] [review]
Patch in preferred format

Comment 2 John (J5) Palmieri 2008-04-24 08:26:15 UTC

Looks good, we may need to set disable to enable since by default we have had it off for some time.  I'm bringing the discussion on the D-Bus list.

Comment 3 Scott James Remnant 2008-04-24 08:28:53 UTC

Possibly, though I'm running with it enabled now and not encountering any new or strange problems.

If it's left disabled, #15589 will need to be attended to with some kind of refcounting for the objects

Comment 4 John (J5) Palmieri 2008-04-24 08:45:09 UTC

Never mind, that was after 1.0 so it is ok to fix as it.

Comment 5 John (J5) Palmieri 2008-05-07 07:27:58 UTC

*** Bug 15455 has been marked as a duplicate of this bug. ***

Comment 6 Havoc Pennington 2008-05-13 12:03:37 UTC

I'm pretty sure the bus is outrageously slow with this disabled, too (at least if you have any policy rules based on group membership)

Comment 7 Colin Walters 2008-05-30 08:17:07 UTC

commit 80306140b9c91bce319f50a55694f205a9a4392f
Author: Colin Walters <walters@verbum.org>
Date:   Fri May 30 11:14:46 2008 -0400

    Bug 15588: Fix typo in #ifdef for userdb cache (Scott James Remnant)
    
    	* dbus/dbus-userdb-util.c, dbus/dbus-userdb.c: Correct name of
     	macro used in #ifdef block to match that defined by configure,
     	otherwise the userdb cache will never be enabled.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.