| Summary: | PACKAGE_SCRIPT_DIR should be libexecdir based | ||
|---|---|---|---|
| Product: | hal | Reporter: | Stanislav Brabec <sbrabec> |
| Component: | hald | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | medium | CC: | danny.kukawka |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.freedesktop.org/hal/commit/?id=fa05be92c4b924ce6a791d2e7c46a467cccf357e | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 15768 | ||
| Bug Blocks: | |||
| Attachments: |
hal-script_dir.patch
hal-script-dir.patch |
||
|
Description
Stanislav Brabec
2008-04-30 06:11:48 UTC
Created attachment 16262 [details] [review] hal-script_dir.patch Proposed fix. Not tested in run, as it needs fix of more packages, but all apparent occurrences were changed. This change would affect: Redhat openSUSE on bi-arch platforms This change would not affect: Debian I can imagine better fix adding --with-hald-addon-dir and --with-hald-script-dir to configure. I can prepare it. I'd rather not change this as I'm not convinced it won't break anything... It breaks anyway. libdir differs distribution from distribution. There is no convenient way to get scriptdir (see bug 15768), third party package authors have to guess (and many of them guess incorrectly, as it varies between /usr/lib/hal/scripts, /usr/lib64/hal/scripts, /usr/lib32/hal/scripts). Yes, it will change default, but it is easy to select libexecdir properly to keep current behavior of particular distro. It would be responsibility of distribution packagers while upgrading. See related problem for openSUSE: https://bugzilla.novell.com/show_bug.cgi?id=304316 Created attachment 19103 [details] [review] hal-script-dir.patch New patch heavily depends on features introduced by the new patch in bug 15768 and changes default patch as they should be by definition of libdir and libexecdir. After this patch, hal compiled with default options should not introduce bi-architectural clashes (32-bit script is perfectly usable by 64-bit hald, so there is no reason to split them into two directories). The default path before this patch was not portable, that is why I propose to accept this patch. Distribution maintainers should be warned about this change. Packagers of non-bi-arch distros can easily keep the paths as they were before, packagers of bi-arch distros have to decide about new setup. Missed that bug, sorry. Hope that is fixed with the change to --libexecdir=/usr/lib/hal. Otherwise let me know. Thanks! Yes, it seems that http://cgit.freedesktop.org/hal/commit/?id=fa05be92c4b924ce6a791d2e7c46a467cccf357e will do the change in the current git version. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.