Bug 15782

Summary:	sun rules reference nonexistent symbols
Product:	xkeyboard-config	Reporter:	Mohammed Adnène Trojette <adn>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	jcristau
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=469335
Whiteboard:
i915 platform:		i915 features:
Attachments:	correct reference to nonexistent symbols

Description Mohammed Adnène Trojette 2008-04-30 17:09:26 UTC

Created attachment 16281 [details] [review]
correct reference to nonexistent symbols

Hello,

here is the content of a Debian bug report (#469335).

Both xorg rules model sun5 as sun rules model type5 reference
symbols sun_vndr/us(sun5), but symbols/sun_vndr/us has no
sun5, but only type5. (and the same for sun4 and sun6 in sun)

I guess this is the reason why I get a non-working keyboard and the
following error when starting X (approx, typed in):

Error:   No Symbols named "sun5" in the include file "sun_vndr/us"
         Exiting
         Abondoning symbols file "default"

With the following patch the error is gone (I guess it still needs
modification to all the not-us files in symbols, as they seem to reference
sun5 instead of type5, too.

The keyboard mapping is also different (though my Sun type 5c keyboard
produce very absurd keys with it still, though they seem to be the same
as with the xkb-data-legacy package now)

Comment 1 Sergey V. Udaltsov 2008-05-01 15:03:55 UTC

Next release is going to see rules/sun* dropped. Confirmed with Sun people - no need in that obsolete and unmaintained stuff. If you really need those layouts - would you consider submitting patches to rules/base* files?

Comment 2 Mohammed Adnène Trojette 2008-05-06 16:31:42 UTC

The patch already contains a part about rules/base.
Maybe I shouldn't have 'cat sun.diff base.diff'...

Comment 3 Julien Cristau 2009-01-28 04:14:36 UTC

Reopening as the rules/base part still applies.  From rules/base.ml_s.part:
  sun4          $nonlatin               =       latin+sun_vndr/us(sun4)+%l%(v):2
  sun4          *                       =       latin+sun_vndr/us(sun4)+%l%(v)
  sun5          $nonlatin               =       latin+sun_vndr/us(sun5)+%l%(v):2
  sun5          *                       =       latin+sun_vndr/us(sun5)+%l%(v)

sun_vndr/us(sun4) and sun_vndr/us(sun5) don't exist.
These should probably be changed to type4 and type5, respectively?

Comment 4 Sergey V. Udaltsov 2009-01-28 13:21:26 UTC

fixed, committed, please check.

Comment 5 Julien Cristau 2009-01-29 01:36:01 UTC

> --- Comment #4 from Sergey V. Udaltsov <svu@gnome.org>  2009-01-28 13:21:26 PST ---
> fixed, committed, please check.
> 
looks good, thanks!

Comment 6 Julien Cristau 2009-05-30 09:09:14 UTC

Bah, looks like we missed one in rules/base.ml1_s.part:
  sun4          *                       =       latin+sun_vndr/us(sun4)+%l[1]%(v[1])
  sun5          *                       =       latin+sun_vndr/us(sun5)+%l[1]%(v[1])

Comment 7 Sergey V. Udaltsov 2009-06-09 03:14:53 UTC

Well spootted, thanks, committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.