Bug 1584

Summary: support for Linux/HPPA
Product: xorg Reporter: Stefan Dirsch <sndirsch>
Component: Server/GeneralAssignee: Egbert Eich <eich>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: eich, mat, pma, roland.mainz
Version: git   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 1624    
Attachments:
Description Flags
p_hppa.diff
none
p_hppa.diff
none
parisc-gcc-defines
none
Yet another improved patch none

Description Stefan Dirsch 2004-10-10 08:35:20 UTC
I'll attach a patch, which adds support HPPA.
Comment 1 Stefan Dirsch 2004-10-10 08:35:47 UTC
Created attachment 1067 [details] [review]
p_hppa.diff
Comment 2 Stefan Dirsch 2004-10-11 02:36:27 UTC
Needs to be discussed outside of Bugzilla first.  
 
Comment 3 Stefan Dirsch 2004-10-13 01:36:19 UTC
reopen for discussion. 
Comment 4 Stefan Dirsch 2004-10-13 01:37:25 UTC
. 
Comment 5 Stefan Dirsch 2004-10-13 01:38:13 UTC
Created attachment 1092 [details] [review]
p_hppa.diff

Improved patch.
Comment 6 Stefan Dirsch 2004-10-13 01:49:16 UTC
Egbert, for building use khisanth, for Xserver testing use crow (Visualize EG, 
fbdev driver). 
Building X11 programs work, X11 programs via remote work as well (just tested 
with xdvi via ssh). 
Egbert complains about missing entries in imakemdep.h. Berthold thinks that 
they might not be required at all because of default defines in gcc. I'll 
attach these default defines. 
 
Comment 7 Stefan Dirsch 2004-10-13 01:52:21 UTC
Created attachment 1093 [details]
parisc-gcc-defines

PA-Risc gcc default defines
Comment 8 Egbert Eich 2004-10-17 01:36:45 UTC
> Egbert complains about missing entries in imakemdep.h. Berthold thinks that 
> they might not be required at all because of default defines in gcc. I'll 
> attach these default defines. 
The way imake works they are still required.
I still cannot build on khisanth as a lot of utilities and libs are missing.
I need flex, bison, ncurses (+devel), libpng (+devel), expat (+devel) and maybe
some other stuff.
Comment 9 Egbert Eich 2004-10-17 01:40:14 UTC
I will commit the second part but I will not commit the Imake stuff for now.
Comment 10 Stefan Dirsch 2004-10-17 03:44:44 UTC
flex, bison, ncurses (+devel), libpng (+devel), expat is installed now on 
khisanth. Thanks for committing. You can commit the imake stuff later, when 
it's better investigated. As long as it's tracked. 
 
Comment 11 Egbert Eich 2004-10-18 02:41:14 UTC
Thanks Stefan! I have decided to commit everything altogether as I have not
found any place which uses set_socket_opt() unset_socket_opt(). Therefore this
stuff can possibly be dropped altogether.
Comment 12 Egbert Eich 2004-10-18 10:05:34 UTC
Created attachment 1126 [details] [review]
Yet another improved patch

This is another version of the patch. It removes os/hpsocket.c instead of
fixing it. I don't see where it is used.
Maybe Paul Anderson from HP can help us.
Comment 13 Egbert Eich 2004-10-18 10:09:31 UTC
Paul, could you please check what this os/hpsocket.c is for.
I cannot see it used anywhere and on a PA-RISC where it gets build it's not needed. 
Once the build with all these patches has succeeded I will commit it.
Comment 14 Paul Anderson 2004-10-18 12:31:07 UTC
(In reply to comment #13)
> Paul, could you please check what this os/hpsocket.c is for.
> I cannot see it used anywhere and on a PA-RISC where it gets build it's not 
needed. 
> Once the build with all these patches has succeeded I will commit it.

I can't speak for the Linux/HPPA port, but this function isn't used on
HP-UX/HPPA.  I did find some references to it in some very old code 
(such as back in the X11R5 or before timeframe), but we're not calling it
now. It was probably used long ago but remained in the code even after it
was no longer needed.  I don't have any objections to removing it from the
code.  
Comment 15 Egbert Eich 2004-10-19 06:51:23 UTC
Thanks Paul!
I've committed a Linux/HPPA patch and reomved this file.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.