Bug 15889

Summary:	Improve XEP-0153 compliance in interactions with our other resources
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	minor
Priority:	low
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2008-05-09 05:03:41 UTC

_grab_avatar_sha1 in src/presence-cache.c says:

+      /* FIXME: according to XEP-0153,
+       * if (handle == priv->conn->parent.self_handle), then we MUST
+       * immediately send a presence update with an empty update child
+       * element (no photo node), then re-download our own vCard;
+       * when that arrives, we may start setting the photo node in our
+       * presence again.
+       *
+       * At the moment we ignore that requirement and trust that our other
+       * resource is getting its sha1 right - but it's a good policy to not
+       * trust anyone's XMPP implementation :-) */

We should add the extra checks.

Comment 1 Simon McVittie 2008-07-17 07:14:51 UTC

What was this doing filed against tp-glib? I must have been asleep. Assigning to Gabble like it should have been.

Comment 2 Will Thompson 2009-10-06 05:03:57 UTC

This was fixed in 0.8.5.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.