Bug 15959

Summary:	Clarify "Save media as" button label
Product:	swfdec	Reporter:	Matthew Paul Thomas <mpt>
Component:	plugin	Assignee:	swfdec ml <swfdec>
Status:	RESOLVED FIXED	QA Contact:	swfdec ml <swfdec>
Severity:	trivial
Priority:	medium
Version:	0.6.0
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	make save media as button label hig compliant

Description Matthew Paul Thomas 2008-05-16 03:47:10 UTC

swfdec-mozilla 0.6.0-2ubuntu1, Ubuntu 8.04

In the "Properties" window for a Flash object, there is a button labelled "Save media as".

There are three issues with this label:
1. Just clicking the button by itself doesn't save the media; you need to specify the destination. Therefore the label should end in an ellipsis.
2. Button labels should use title capitalization, e.g. "Save Media As...".
3. The "Save As…" wording is normally used only when there is a separate "Save" command that updates the existing file. Here there isn't such a command, so the "As" isn't necessary.

In conclusion, I suggest this button be labelled "Save…".

Comment 1 Riccardo Magliocchetti 2008-05-21 01:59:37 UTC

Renamed, two bugs with same title is confusing.

Comment 2 Riccardo Magliocchetti 2008-05-21 02:52:31 UTC

Personally i'd like "Save Media" or just "Save", without ellipsis. For comparison in openoffice.org the "Save" has no ellipsis when the document is new.

Comment 3 Benjamin Otte 2008-05-21 04:56:11 UTC

The ellipsis is required per HIG - see http://library.gnome.org/devel/hig-book/stable/controls-buttons.html
"Save media" is reduntant, as everyone knows it's about meia only, and not about your children or whatever.

Comment 4 Riccardo Magliocchetti 2008-05-21 08:45:08 UTC

Created attachment 16663 [details] [review]
make save media as button label hig compliant

Change button label from "Save media as" to "Save..." as suggested by Matthew.

Comment 5 Benjamin Otte 2008-05-24 02:27:33 UTC

commit befb86498165b8016f7156f0bb3fb25c135204f4
Author: Riccardo Magliocchetti <riccardo@datahost.it>
Date:   Sat May 24 11:25:57 2008 +0200

    make save media as button label hig compliant (fixes #15959)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.