Bug 16037

Summary:	use wext ioctl instead of sysfs
Product:	hal	Reporter:	Johannes Berg <johannes>
Component:	hald	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	danny.kukawka, marcel
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	15986
Bug Blocks:
Attachments:	patch to use ioctl patch to use wext ioctl instead of sysfs updated to hal 0.5.11

Description Johannes Berg 2008-05-20 10:14:09 UTC

Created attachment 16654 [details] [review]
patch to use ioctl

The canonical way to check whether a network interface has wireless extensions is to try calling the SIOCGIWNAME ioctl on it. The attached patches does that for hal.

Since the patch depends on the one in bug 15986, I'm marking this one as depending it.

Comment 1 Johannes Berg 2008-05-22 00:20:50 UTC

Created attachment 16676 [details] [review]
patch to use wext ioctl instead of sysfs

The other patch had inverted arguments in strncpy(), this fixes it.

Comment 2 Dan Williams 2008-05-22 12:01:42 UTC

Created attachment 16696 [details] [review]
updated to hal 0.5.11

You probably want this version against hal 0.5.11; your has phy8011 bits in it which are actually wiphy in the latest hal git.  I'm assumig the phy80211 code is older?

Comment 3 Johannes Berg 2008-05-22 12:08:10 UTC

Au contraire! This depends on the patch I posted in bug 15986 which changes hal (from git) to use phy80211 which is the correct path.

Comment 4 Dan Williams 2008-05-22 14:59:25 UTC

Patch works for me.

Comment 5 Danny Kukawka 2008-05-23 08:32:32 UTC

commit 41073645ea95e0bb478d6b26871a1bc4ccf832d1
Author: Johannes Berg <johannes@sipsolutions.net>
Date:   Fri May 23 17:31:51 2008 +0200

    use wext ioctl instead of sysfs to detect wireless

    The canonical way to check whether a network interface has wireless
    extensions is to try calling the SIOCGIWNAME ioctl on it.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.