| Summary: | glint 1.2.0 driver segfaults with 1.4.0.90 and 1.3.0.0 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Tobias Klausmann <klausman-gentoo> | ||||
| Component: | Driver/glint | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | normal | ||||||
| Priority: | medium | CC: | armin76 | ||||
| Version: | unspecified | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-glint.git;a=commit;h=c4b0de8dc27ce4c3145dca36f75f3b3e4fdd20b9 | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
Tobias Klausmann
2008-05-22 06:28:03 UTC
Armin and I narrowed it down to this commit: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-glint.git;a=commit;h=c4b0de8dc27ce4c3145dca36f75f3b3e4fdd20b9 Unfortunately, my knowledge of the guts of libpciaccess and the glint chip is nonexistant, so I can't really narrow it down further. I'm quite willing to test patches, though. On Fri, May 23, 2008 at 10:36:58 -0700, bugzilla-daemon@freedesktop.org wrote: > --- Comment #1 from Tobias Klausmann <klausman-gentoo@schwarzvogel.de> 2008-05-23 10:36:58 PST --- > Armin and I narrowed it down to this commit: > > http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-glint.git;a=commit;h=c4b0de8dc27ce4c3145dca36f75f3b3e4fdd20b9 > > Unfortunately, my knowledge of the guts of libpciaccess and the glint chip is > nonexistant, so I can't really narrow it down further. I'm quite willing to > test patches, though. > Can you test the following: diff --git a/src/glint_driver.c b/src/glint_driver.c index eb375ec..47127f9 100644 --- a/src/glint_driver.c +++ b/src/glint_driver.c @@ -1408,7 +1408,7 @@ GLINTPreInit(ScrnInfoPtr pScrn, int flags) pGlint->IOAddress = pGlint->pEnt->device->IOBase; from = X_CONFIG; } else { - pGlint->IOAddress = PCI_REGION_BASE(pGlint->MultiPciInfo[0], 0, REGION_M + pGlint->IOAddress = PCI_REGION_BASE(pGlint->PciInfo, 0, REGION_MEM) & 0x } if ((IS_J2000) && (pGlint->Chipset == PCI_VENDOR_3DLABS_CHIP_GAMMA)) { The corresponding change in the pciaccess conversion looks suspicious. Thanks, Julien Created attachment 17336 [details] [review] patch (In reply to comment #2) > Can you test the following: the patch was messed up in email, so i've attached it this time. Works fine! Thanks.
(II) LoadModule: "glint"
(II) Loading /usr/lib/xorg/modules/drivers//glint_drv.so
(II) Module glint: vendor="X.Org Foundation"
compiled for 1.3.0, module version = 1.2.0
Module class: X.Org Video Driver
ABI class: X.Org Video Driver, version 1.2
> --- Comment #5 from Raúl Porcel <armin76@gentoo.org> 2008-06-30 06:59:57 PST --- > Works fine! Thanks. > Thanks for testing; I pushed the patch to master. commit 9c4f5ec0c8a5b48b9b923798175cc6e66932f8ed Author: Julien Cristau <jcristau@debian.org> Date: Tue Jun 24 03:17:32 2008 +0200 Fix regression from pciaccess conversion (bug#16060) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.