Bug 16114

Summary:	[patch] wincaps-to-uscore property names for GetAll()
Product:	dbus	Reporter:	Dan Williams <dcbw>
Component:	GLib	Assignee:	Rob Taylor <rob.taylor>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	normal
Priority:	medium	CC:	liblit, walters, zeuthen
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	uscore property names for GetAll() too new version that doesn't use-after-free in the error case

Description Dan Williams 2008-05-27 06:35:36 UTC

Created attachment 16763 [details] [review]
uscore property names for GetAll() too

Everywhere else converts the property names, but GetAll() doesn't seem to.  Results in GetAll() returning no properties, becuase the properties from the introspection data are WinCaps, but the gobject properties are uscored.

Comment 1 Dan Williams 2008-05-27 06:43:59 UTC

Created attachment 16764 [details] [review]
new version that doesn't use-after-free in the error case

Comment 2 David Zeuthen (not reading bugmail) 2008-05-27 07:43:19 UTC

Sounds sensible (didn't look at the patch though) to me, I didn't think of that when writing the original GetAll() patch.

Comment 3 Colin Walters 2008-05-27 10:52:40 UTC

So this isn't an API/ABI change in any way, it was basically that the old GetAll didn't work?

Comment 4 David Zeuthen (not reading bugmail) 2008-05-27 12:00:48 UTC

(In reply to comment #3)
> So this isn't an API/ABI change in any way, it was basically that the old
> GetAll didn't work?

Sort of. But keep in mind that the patch for GetAll() was never in any release.

Comment 5 Colin Walters 2008-05-27 12:02:30 UTC

Ok, sounds good then; David can you commit?

Comment 6 Dan Williams 2008-05-27 12:05:23 UTC

This is an ABI change, but if you were using dbus-glib such that this patch affects you, then Get/Set wouldn't have worked for you already either.  Get/Set operations convert the WinCaps property name to a u-scored name, so if your GObject properties were WinCaps already (in which case this patch would break you) then the Get/Set would fail for your object because the g_object_class_find_property() for the WinCaps->u-scored name would already fail.

Comment 7 Colin Walters 2008-06-05 15:00:44 UTC

commit d1b80d803a0268bd4b3dd5b9a9522230461f2947
Author: Dan Williams <dcbw@redhat.com>
Date:   Thu Jun 5 17:57:53 2008 -0400

    Bug 16114 [patch] wincaps-to-uscore property names for GetAll()
    
    	* dbus/dbus-gobject.c: We need to uscore property names
    	so that we actually find the right properties.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.