Bug 16131

Summary:	polkit-resolve-exe-helper.c #include pam headers that it does not use
Product:	PolicyKit	Reporter:	Kaj-Michael Lang <milang>
Component:	daemon	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED INVALID	QA Contact:	David Zeuthen (not reading bugmail) <zeuthen>
Severity:	major
Priority:	medium	CC:	virdiq
Version:	unspecified
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Trivial patch to remove unused pam header

Description Kaj-Michael Lang 2008-05-28 05:31:13 UTC

polkit-resolve-exe-helper.c includes security/pam_appl.h, but does not use any pam functions. Blindly including the pam header breaks a shadow password build.

Trivial patch for current git attached.

Comment 1 Kaj-Michael Lang 2008-05-28 05:32:06 UTC

Created attachment 16787 [details] [review]
Trivial patch to remove unused pam header

Comment 2 Kaj-Michael Lang 2008-07-23 08:12:13 UTC

Ping? Not fixed in 0.9

Comment 3 virdiq 2008-10-04 09:25:20 UTC

Downstream Gentoo bugzilla entry for this bug: http://bugs.gentoo.org/show_bug.cgi?id=239554

Comment 4 David Zeuthen (not reading bugmail) 2009-10-21 10:35:51 UTC

This bug report is for the old version of PolicyKit. Closing as all of the code has been rewritten. Please reopen if the bug report applies to the latest version of PolicyKit. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.