Bug 16212

Summary:	[PATCH] xdg-* doesn't work with KDE4 (kde4-config)
Product:	Portland	Reporter:	Elias Probst <mail>
Component:	xdg-utils	Assignee:	Portland Bugs <portland-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	lmenut, rdieter
Version:	1.0
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	xdg-open supports now KDE3.x and KDE4.x patch for kfmclient_fix_exit_code with kde4

Description Elias Probst 2008-06-02 20:11:05 UTC

Created attachment 16882 [details] [review]
xdg-open supports now KDE3.x and KDE4.x

As the tool for determining KDE configuration values was renamed from kde-config to kde4-config in KDE4.x, the xdg-open utility doesn't work properly in KDE4 environments.

The attached patch should fix this.

Comment 1 Luc Menut 2008-08-10 14:07:59 UTC

(In reply to comment #0)
> Created an attachment (id=16882) [details]
> xdg-open supports now KDE3.x and KDE4.x
> 
> As the tool for determining KDE configuration values was renamed from
> kde-config to kde4-config in KDE4.x, the xdg-open utility doesn't work properly
> in KDE4 environments.
> 
> The attached patch should fix this.

It doesn't fix correctly the bug when both kde3 and kde4 are installed.
Moreover, I change the summary because the function kfmclient_fix_exit_code() from all xdg-* scripts is concerned by this bug.

Comment 2 Luc Menut 2008-08-10 14:13:55 UTC

Created attachment 18200 [details] [review]
patch for kfmclient_fix_exit_code with kde4 

This patch replaces kde-config by kde${KDE_SESSION_VERSION}-config 
(http://techbase.kde.org/KDE_System_Administration/Environment_Variables#KDE_SESSION_VERSION)
in kfmclient_fix_exit_code() in all the xdg-* scripts.

best regards,
Luc

Comment 3 Rex Dieter 2008-08-10 21:48:39 UTC

Many thanks, and from the looks of it, your patch looks appealing.  I'll see about integrating it soon.

Comment 4 Rex Dieter 2008-11-21 11:09:54 UTC

OK, patch integrated (awhile ago at akademy 2008, but I failed to followup to close this).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.