Bug 1625

Summary: [XKB] bad definition of IsModifierKey()
Product: xorg Reporter: Stanislav Brabec <sbrabec>
Component: Lib/otherAssignee: Daniel Stone <daniel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: dberkholz, eich, erik.andren, mat, sndirsch
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Stanislav Brabec 2004-10-13 10:24:38 UTC 
To be IsModifierKey() defined properly in X11/Xutil.h, XK_XKB_KEYS has to be
defined previously. This is done in X11/keysym.h. But this file is not resourced
and compiler gets incorrectly defined macro IsModifierKey(), unless it
explicitly includes X11/keysym.h before X11/Xutil.h.

This causes bad definition of IsModifierKey() in Emacs.

Fix: Add
#include <X11/keysym.h>
to X11/Xutil.h

It causes for example bad function of AltGr in Emacs.
Comment 1 Stefan Dirsch 2004-10-13 11:56:36 UTC 
Matthias, Egbert, see 
 
  http://bugzilla.suse.de/show_bug.cgi?id=47192 
 
for more details.
Comment 3 Erik Andren 2006-04-07 16:29:06 UTC 
Looking at the Redhat bugs fixes has gone into Emacs and not to Xorg. 
Which implicates an error in Emacs and not xorg.
Comment 4 Stanislav Brabec 2006-04-07 21:29:47 UTC 
On my opinion the "fix" of Emacs (change of include order) is a only a work-around.

The bug is in in X headers (undocumented change of behavior depending on order
of includes).
Comment 5 Daniel Stone 2006-04-08 01:49:59 UTC 
fixed in git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.