| Summary: | Server leaks minorly in RegisterExtensionNames | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Ben Gamari <bgamari> | ||||
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | normal | ||||||
| Priority: | medium | CC: | ewalsh | ||||
| Version: | git | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
Ben Gamari
2008-06-23 17:38:41 UTC
Created attachment 17338 [details] [review] Patch Hi, please look at RegisterRequestName, RegisterEventName, and RegisterErrorName in that file. You will see that they save the result of the strdup in a global array, which is later freed in dixResetRegistry. So the patch given is not correct. However, there is a leak in the case where the line is invalid and the loop continues. I have a patch that I will push up shortly. OK, patch pushed to master and server-1.5-branch. This was a pretty major leak. Thanks a lot for reporting it. (In reply to comment #3) > OK, patch pushed to master and server-1.5-branch. This was a pretty major > leak. Thanks a lot for reporting it. > No worries. Sorry about the bad patch earlierThere are plenty more where that came from too. Valgrinding xserver is quite an illuminating experience. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.