Bug 16512

Summary: ATI driver does not build
Product: xorg Reporter: Brad Smith <brad>
Component: Driver/RadeonAssignee: xf86-video-ati maintainers <xorg-driver-ati>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: blocker    
Priority: high CC: airlied
Version: git   
Hardware: All   
OS: OpenBSD   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
autoconf patch
none
Radeon driver src code diff none

Description Brad Smith 2008-06-24 23:40:04 UTC 
As of commit f29976d12cc2020cd80c90fa3fd4b25c031559ba the ATI driver no longer builds on almost all OS's X.Org supports.

Looking at the X server there is a comment like so in the autoconf script..

# Checks for headers/macros for byte swapping
# Known variants:
#       <byteswap.h> bswap_16, bswap_32, bswap_64  (glibc)
#       <sys/endian.h> __swap16, __swap32, __swap64 (OpenBSD)
#       <sys/endian.h> bswap16, bswap32, bswap64 (other BSD's)
#       and a fallback to local macros if none of the above are found

and following is some checks to find the right macros to use. Most likely something similar should be copied over to the ATI driver.
Comment 1 Dave Airlie 2008-06-25 00:11:14 UTC 
please try building with latest head to see if this is fixed.

extra points if you can build on powerpc.
Comment 2 Brad Smith 2008-06-25 20:34:13 UTC 
Created attachment 17384 [details] [review]
autoconf patch
Comment 3 Brad Smith 2008-06-25 20:35:18 UTC 
This is very close. It seems the autoconf tests for endian.h are broken as is and sys/types.h is needed to fix this. This patch is also necessary for the X server.
Comment 4 Brad Smith 2008-06-26 00:19:13 UTC 
Although this is not related to this particular bug I thought I should mention it here anyway so you will see this and fix it. A recent change from Alex in the tree changed some code around and added a line like so in radeon_textured_videofuncs.c around line 645...

if (IS_R300_3D | IS_R500_3D) {

This should be || instead of |.
Comment 5 Brad Smith 2008-06-26 00:27:44 UTC 
Created attachment 17389 [details] [review]
Radeon driver src code diff

Actually using grep on the code showed a few more instances.
Comment 6 Alex Deucher 2008-06-26 07:23:14 UTC 
Patches applied.  thanks:

dca522355a9039eca6efaba3b36397b246800f94
32e1d1daf4f68ea37624afaa2bc1ea7742e1163b

Can we close this bug now?
Comment 7 Brad Smith 2008-06-26 08:30:16 UTC 
Yes. Go ahead.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.