Bug 16642

Summary: Please use the system perl
Product: system-tools-backends Reporter: Emilio Pozuelo Monfort <pochu27>
Component: initAssignee: Carlos Garnacho Parro <carlosg>
Status: RESOLVED FIXED QA Contact: Carlos Garnacho Parro <carlosg>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Use the system perl

Description Emilio Pozuelo Monfort 2008-07-08 11:56:40 UTC
Created attachment 17579 [details] [review]
Use the system perl

From https://bugs.launchpad.net/bugs/199134

Some s-t-b scripts don't use the system perl, which could lead to a broken gnome-system-tools if the user installs a broken perl.

The attached patch fixes this by setting the shebang to /usr/bin/perl
Comment 1 Milan Bouchet-Valat 2009-08-19 02:00:14 UTC
Not sure that's the perfect fix. What if we want to use a custom version of perl, say using jhbuild? Shouldn't 'env perl' return the default perl interpreter, and not some random one? Just trying to work things out.
Comment 2 Emilio Pozuelo Monfort 2009-08-19 19:09:32 UTC
I think the common practice is to use the system one:

emilio@saturno:/usr/bin$ grep -E "\#\! ?/usr/bin/env perl" * | wc -l
12
emilio@saturno:/usr/bin$ grep -E "\#\! ?/usr/bin/perl" * | wc -l
350
emilio@saturno:/usr/bin$ 
Comment 3 Milan Bouchet-Valat 2009-08-31 06:03:54 UTC
Well, with such statistics, I'd need strong arguments, which I don't really have. ;-)

It just feels strange to me that you don't have any way to use a custom perl for a given program if you want, just like you build it against a custom library. But I don't think anybody will want to do that with the stb, so better prevent breaking them.

Pushed as 2916c228e818dca562a963958f3f5db40d579018 (I've fixed a few more files that still used /usr/bin/env). Thanks for that patch!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.