| Summary: | __glXQueryContextInfo in libGL can segfault if GLX version > 1.2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Adam Jackson <ajax> | ||||
| Component: | Server/Ext/GLX | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | high | CC: | dcb314, roland.mainz | ||||
| Version: | git | ||||||
| Hardware: | x86 (IA32) | ||||||
| OS: | Linux (All) | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
Adam Jackson
2004-10-19 16:30:38 UTC
Created attachment 1132 [details] [review] [FIXED_X11R68x] client-glx-wui.patch trivial patch, fix from Ian Romanick. fixed in Mesa CVS, which is where the GLX client code lives now. this will get fixed upstream when next we import Mesa. roland, you'll probably want to make sure Mesa gets updated in 6.8.2, for this reason among others. ajax@nwnk.net wrote: > roland, you'll probably want to make sure Mesa gets updated in 6.8.2, for this > reason among others. Primary reason for me was that the unpatched GLX code looks like a quite good way to crash an application (even the untested patch is then better than the original code - it's untested but at least correct in theory :) ... Comment on attachment 1132 [details] [review] [FIXED_X11R68x] client-glx-wui.patch Nominating for X11R6.8.x as the unpatched code is likely going to crash applications. ajax: Uhm... did you commit this to Xorg trunk yet ? no, i did not. the GLX client code now lives in Mesa where it belongs, and the copy of Mesa in extras/ hasn't been synced yet. would you like me to do so? ajax@nwnk.net wrote: > no, i did not. the GLX client code now lives in Mesa where it belongs, and > the copy of Mesa in extras/ hasn't been synced yet. would you like me to do > so? Yes, if possible. Just to avoid that someone starts to complain that a patch was commited to the X11R6.8.x branch without having the same change applied to the trunk (well, and to get the patch tested in Xorg trunk). *** Bug 1857 has been marked as a duplicate of this bug. *** applied to HEAD. Comment on attachment 1132 [details] [review] [FIXED_X11R68x] client-glx-wui.patch Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone call. Please don't commit it yourself, I'll handle that once the CVS service is available again. Comment on attachment 1132 [details] [review] [FIXED_X11R68x] client-glx-wui.patch Patch checked-in into X11R6.8.x stable branch: cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.38; previous revision: 1.365.2.37 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/lib/GL/glx/glxcmds.c,v <-- glxcmds.c new revision: 1.3.4.1; previous revision: 1.3 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.