Bug 16797

Summary: Tube close message sent twice in 1-1 tubes
Product: Telepathy Reporter: Alban Crequy <alban.crequy>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: minor    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Alban Crequy 2008-07-21 09:38:41 UTC 
When the remote contact closes the tube with a close message, Gabble closes the tube and sends a close message to the remote contact. The second close message is not needed. It is not in the proto-xep:
http://telepathy.freedesktop.org/xmpp/tubes.html

A tube can be closed because:

1/ a local application calls the D-Bus method call CloseTube
 or
2/ the remote contact sends the close message in a <message> stanza

In the first case, it is appropriate to send the close message to the remote contact. In the second case, we don't need to send the close message because the contact already knows that the tube has to be closed since it requested it. This bug is about the second case.

When the unneeded close message arrives, the tube is already closed, so the tube id is no longer known by Gabble and the message is ignored. So this bug is harmless.
Comment 1 Alban Crequy 2008-10-31 06:08:07 UTC 
Fixed by commit 51544bf01747e5a3cf4c23bd077ce8b3eba6b32e to 3a75959dc4e72632c340ebf7ba0e7cd5467c50da.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.