| Summary: | Fix build and cleanup of .dir and parts files | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Igor Stirbu <igor.stirbu> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | andreimpopescu |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Fix .dir build and cleanup | ||
|
Description
Igor Stirbu
2008-08-06 07:44:33 UTC
Thanks, that's a good patch. Except for the .PHONY for *.dir files. Since they are real files, why did you mark this target as .PHONY? I already made some small change to xkbrules.am - but still I'd add .PHONY if you convince me:) The rest is committed. Hello Sergey, (In reply to comment #1) > I already made some small change to xkbrules.am - but still I'd add .PHONY if > you convince me:) Maybe I will not convince you, but I'll try to explain. It's really hard to compute the dependencies of every .dir file and create a general rule that would fit all the cases (you know that :). The .PHONY is a trick to force make into building $(subdir).dir file every time make is run. make, by default, treats all targets as files and .PHONY marks targets as 'not files'. If you have a file called 'all' or 'clean', make would see that file and because the corresponding target has no dependencies, it would not run the commands (unless you mark it as .PHONY). Besides this, I see .PHONY as a good way to 'optimize' Makefiles in order to get rid of redundant stat()s. Thanks, Igor Hello Sergey, (In reply to comment #1) > I already made some small change to xkbrules.am I've looked through your change and it seems to be a better solution that .PHONY. I did not choose the solution with dir_data because I was not sure if all the dependencies are known. Regarding the command in xkbrules.am there xkbcomp is called, all that stuff with 'here' and 'pwd' is redundant because all the paths become relative to the place where it is sourced. Thanks, Igor > I've looked through your change and it seems to be > a better solution that .PHONY. I did not choose the > solution with dir_data because I was not sure if > all the dependencies are known. Ok, now that everbody's happy, let's leave it as it is. > Regarding the command in xkbrules.am there xkbcomp > is called, all that stuff with 'here' and 'pwd' is > redundant because all the paths become relative to > the place where it is sourced. What if the source directory is different from the build directory? Some distributions have that practice... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.