Summary: | MSYS: smiley faces appear in pkg-config output | ||
---|---|---|---|
Product: | pkg-config | Reporter: | Sam Thursfield <ssssam> |
Component: | src | Assignee: | Tollef Fog Heen <tfheen> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | medium | CC: | perry.werneck, ylatuya |
Version: | unspecified | ||
Hardware: | x86 (IA32) | ||
OS: | Windows (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Patch reverting 25e8ca84acd7fc604fbc59213587887d5119d51a |
Description
Sam Thursfield
2008-08-09 17:49:15 UTC
Also, the control character isn't visible if you run the command under msys with rxvt; use msys --norxvt. Okay. It would have been nice to find this two days ago but an alternate solution is here: http://lists-archives.org/gtk-devel/05434-gtk-configure-can-t-find-cairo-pdf.html I guess this is a known issue Fixed using: commit 25e8ca84acd7fc604fbc59213587887d5119d51a Author: Tollef Fog Heen <tfheen@err.no> Date: Sun Dec 6 22:34:35 2009 +0100 Print out \r\n on windows, not just \n This should hopefully fix bug #17053 diff --git a/main.c b/main.c index df25aaa..b9442fc 100644 --- a/main.c +++ b/main.c @@ -645,7 +645,11 @@ main (int argc, char **argv) } if (need_newline) +#ifdef G_OS_WIN32 + printf ("\r\n"); +#else printf ("\n"); +#endif return 0; } Ok, now this have driven me mad for a day since upgrading from 0.23 =) --------------------------------------------------------------------------- NTLMS@NTLMS /opt/workdir/mingw-gtk2-build-2.20 $ echo "`/opt/mingw-gtk2/bin/pkg-config --libs gio-2.0` " -Lc:/opt/mingw-gtk2/lib -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lglib-2.0 -lintl ☺ NTLMS@NTLMS /opt/workdir/mingw-gtk2-build-2.20 $ /opt/mingw-gtk2/bin/pkg-config --version 0.25 --------------------------------------------------------------------------- What version of MSYS/MinGW are you using? I have MSYS 1.0.14 with latest bash, etc., and MinGW with mingwrt-3.18, w32api-3.14 and gcc-4.5.0 (latest everything basically). I tested it both in Console, msys with rxvt and msys --norxvt. If I revert it to just print a \n, it works fine, so it might be that it could be a bug in older MSYS/Bash. Bash version is 3.1.17(1)-release btw. yes, I can confirm that with newest MSYS bash, 0.23 now works and 0.25 does not :( so I recommend reverting the patch. at least the problem is solved :) Created attachment 48585 [details] [review] Patch reverting 25e8ca84acd7fc604fbc59213587887d5119d51a This has been brought up a couple of times on mingw-users@lists.sourceforge.net these last few weeks. Here's the patch I've been using. It reverts 5e8ca84acd7fc604fbc59213587887d5119d51a. Tested in cmd.exe and "sh -i" running in cmd.exe, Console2 and mintty (on a Windows XP box in case it matters). (In reply to comment #6) > Tested in cmd.exe and "sh -i" running in cmd.exe, > Console2 and mintty (on a Windows XP box in case it > matters). Ditto for previous test environments and mintty lately (XP/Vista/7), used a similar patch. Sorry for not attaching a patch earlier and following up on it to get it into 0.26. Cannot seem to get git repo checked out here, so just wondering what the status on this is? Reading these two threads: http://mail.gnome.org/archives/gtk-devel-list/2007-June/msg00066.html http://thread.gmane.org/gmane.comp.gnu.mingw.msys/3284 suggest this is a bug with an older mingw/msys shell. The second thread did report this bug that doesn't seem to be closed: http://sourceforge.net/tracker/index.php?func=detail&aid=925450&group_id=2435&atid=102435 I had a winxp vm here so I went to the trouble of building pkg-config under mingw/msys. Sure enough the issue is there. Interestingly, if you send output from a program with just a \n straight to the terminal, the msys shell apparently converts it to \r\n. However, when the program is run under command substitution (backticks), it will keep just the \n. Anyway, I've applied the patch in 79c768a since this seems to work with newer mingw/msys setups. Please reopen if this becomes an issue again. *** Bug 48663 has been marked as a duplicate of this bug. *** *** Bug 50677 has been marked as a duplicate of this bug. *** |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.