Bug 17277

Summary: [945GM XVideo] upscaling limited by factor of 7
Product: xorg Reporter: David Schleef <ds>
Component: Driver/intelAssignee: Wang Zhenyu <zhenyu.z.wang>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: nanhai.zou
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 16926    
Attachments:
Description Flags
patch none

Description David Schleef 2008-08-24 13:35:52 UTC 
1. Run 'gst-launch videotestsrc ! video/x-raw-yuv,width=80,height=60 ! xvimagesink'
2. Maximize window

The output video is only painted to a subsection of the intended window.
Comment 1 Gordon Jin 2008-08-24 18:14:14 UTC 
Please provide more detailed info according to http://www.intellinuxgraphics.org/how_to_report_bug.html.
Comment 2 David Schleef 2008-08-24 19:30:25 UTC 
Oh duh (i830_video.c):

    /* Clamp dst width & height to 7x of src (overlay limit) */
    if(drw_w > (src_w * 7))
        drw_w = src_w * 7;

    if(drw_h > (src_h * 7))
        drw_h = src_h * 7;

The condition I see in the documentation appears to be src_h/drw_h < 8, that is, src_h < 8*drw_h.  It appears this was "fixed" incorrectly in e784e152.

It seems difficult to believe that this limitation would exist at all for the texture unit.
Comment 3 David Schleef 2008-08-24 19:30:55 UTC 
Created attachment 18486 [details] [review]
patch
Comment 4 Gordon Jin 2008-08-26 18:17:19 UTC 
Jesse thinks this might be right. Zhenyu/Nanhai, could you review and apply?
Comment 5 Wang Zhenyu 2008-09-02 01:28:27 UTC 
yeah, we should only apply those check for overlay. Should the origin check also be kept to guard in that case?
Comment 6 Wang Zhenyu 2008-09-18 00:44:08 UTC 
Patch is pushed, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.