Bug 17297

Summary: UnicodeMap ctor should take const char* rather than char*
Product: poppler Reporter: Caolán McNamara <caolanm>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: trivial fix

Description Caolán McNamara 2008-08-25 09:27:27 UTC 
Created attachment 18506 [details] [review]
trivial fix

The ctor sticks them into GooStrings which take const char*, and following the same pattern removes warnings about const-ness in client apps
Comment 1 Albert Astals Cid 2008-08-25 14:14:19 UTC 
Client apps should not be using UnicodeMap as it's on poppler/ core and we don't guarantee any kind of API/ABI stability there even in between patch releases.

Also i'm not going to fix that because it will only make merging with possible future xpdf versions harder for almost no win.

If client apps do not want to have that warnings they can always use -Wno-write-strings, but they should be really using one of the available frontends(glib/qt/qt4) or helping us create plain C++ frontend in which we can try to guarantee API/ABI stability if the available ones do not suite them.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.